Add support for the signet test network#2387
Merged
remyers merged 3 commits intoACINQ:masterfrom Aug 19, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2387 +/- ##
=======================================
Coverage 84.94% 84.94%
=======================================
Files 198 198
Lines 15280 15286 +6
Branches 640 646 +6
=======================================
+ Hits 12979 12985 +6
Misses 2301 2301
|
t-bast
reviewed
Aug 19, 2022
Member
t-bast
left a comment
There was a problem hiding this comment.
There are a few more things you need to modify:
- in
reference.confyou should update the documentation for thechainparameter to mention signet support - in
NodeParamsyou should update thechain2Hashmap to include the signet case - you should update the release doc to mention signet support in the
Miscellaneous improvements and bug fixessection
Otherwise LGTM 👍
Contributor
Author
|
Tested (by-hand) signet channel open/sendtoroute/close using config files and script commands from lightning-cfg after updating for signet. final tx: https://mempool.space/signet/tx/950936af3ad8aa1fd916c4d9b9cc43cfec50806c0a0147c3339420952c17acf9 |
Contributor
Author
fixed in 75c40c1 |
Contributor
Author
Contributor
Author
|
MempoolTxMonitor successfully detected the channel close on Signet: |
t-bast
approved these changes
Aug 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires 0.24 version of bitcoin-lib (#70) which exposes hash of signet genesis block.