Skip to content

URL Fixes for Glo-30 and SRTM-v3#49

Merged
cmarshak merged 7 commits into
devfrom
fix_aws_glo30_urls
Nov 22, 2022
Merged

URL Fixes for Glo-30 and SRTM-v3#49
cmarshak merged 7 commits into
devfrom
fix_aws_glo30_urls

Conversation

@cmarshak

@cmarshak cmarshak commented Nov 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Fixes #48 and srtm_v3 urls in the DEM tiles.

  • Updates glo_30, glo_90, and glo_90_missing urls within the DEM tiles because 2021 prefix within the bucket has been removed. Also updated notebooks that generates the respective geojsons for each set of tiles.
  • Updates srtm_v3 urls from http to https.
  • Updates readme with instructions on how to update geojson tiles and their url attributes.
  • Added python 3.11 to test github actions

@review-notebook-app

review-notebook-app Bot commented Nov 21, 2022

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@cmarshak cmarshak requested a review from jhkennedy November 22, 2022 00:06
@cmarshak cmarshak marked this pull request as draft November 22, 2022 00:06
@cmarshak cmarshak added bug Something isn't working patch Bump the patch version number of this project labels Nov 22, 2022
@cmarshak

cmarshak commented Nov 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Hey @jhkennedy

The static analysis is failing. Can't totally figure out the asf actions since I am bad with bash redirection: https://github.com/ASFHyP3/actions/blob/main/.github/workflows/reusable-flake8.yml#L29-L31

We can talk about it tomorrow when we meet. The second line (approximately) seems to be fine on my machine: flake8 --max-line-length=120 --import-order-style=pycharm --statistics --application-import-names dem_stitcher

Also, I added 3.11 to the github actions - probably should have had a separate pull request... did not modify the setup.py which I think will actually impact pypi and conda.

@cmarshak cmarshak marked this pull request as ready for review November 22, 2022 00:29
@jhkennedy

jhkennedy commented Nov 22, 2022

Copy link
Copy Markdown
Collaborator

@cmarshak these are the errors that flake8 is reporting:

 ./dem_stitcher/stitcher.py:156:11: E275 missing whitespace after keyword
./dem_stitcher/stitcher.py:157:11: E275 missing whitespace after keyword
./dem_stitcher/stitcher.py:213:11: E275 missing whitespace after keyword
./dem_stitcher/geoid.py:58:11: E275 missing whitespace after keyword
./tests/test_rio_tools.py:14:11: E275 missing whitespace after keyword
./tests/test_rio_tools.py:28:11: E275 missing whitespace after keyword
./tests/test_rio_tools.py:29:11: E275 missing whitespace after keyword
./tests/test_rio_tools.py:30:11: E275 missing whitespace after keyword
./tests/test_rio_tools.py:40:11: E275 missing whitespace after keyword
./tests/test_geoid.py:28:11: E275 missing whitespace after keyword
./tests/test_geoid.py:55:15: E275 missing whitespace after keyword
./tests/test_window.py:81:11: E275 missing whitespace after keyword
./tests/test_window.py:100:11: E275 missing whitespace after keyword
./tests/test_window.py:126:11: E275 missing whitespace after keyword
./tests/test_window.py:144:11: E275 missing whitespace after keyword
./tests/test_window.py:162:11: E275 missing whitespace after keyword
./tests/test_window.py:205:11: E275 missing whitespace after keyword
./tests/test_missing.py:30:11: E275 missing whitespace after keyword
./tests/test_missing.py:47:11: E275 missing whitespace after keyword
./tests/test_missing.py:72:11: E275 missing whitespace after keyword
./tests/test_stitcher.py:98:11: E275 missing whitespace after keyword
./tests/test_stitcher.py:143:11: E275 missing whitespace after keyword
./tests/test_stitcher.py:196:11: E275 missing whitespace after keyword
23    E275 missing whitespace after keyword

@jhkennedy

jhkennedy commented Nov 22, 2022

Copy link
Copy Markdown
Collaborator

@cmarshak yes, that flake8 command looks correct.

@cmarshak

cmarshak commented Nov 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Thank you, Joe - It took you reminding me (I am sorry for wasting your time) to remember that assert keyword is not being correctly tracked by my VS Code. assert(<blah>) is not ok anymore.

Thanks again. Will fix all.

jhkennedy
jhkennedy approved these changes Nov 22, 2022
View reviewed changes

@jhkennedy jhkennedy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I think it's fine to include py 3.11 here

@cmarshak cmarshak merged commit 32234bb into dev Nov 22, 2022
@cmarshak cmarshak deleted the fix_aws_glo30_urls branch November 22, 2022 02:10
cmarshak added a commit to ACCESS-Cloud-Based-InSAR/DockerizedTopsApp that referenced this pull request Nov 29, 2022
@cmarshak
Update environment for dem-stitcher with new urls
6b521cc 
See ACCESS-Cloud-Based-InSAR/dem-stitcher#49
@cmarshak cmarshak mentioned this pull request Nov 29, 2022
Merged
@cmarshak cmarshak mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhkennedy jhkennedy jhkennedy approved these changes

Assignees

No one assigned

Labels

bug Something isn't working patch Bump the patch version number of this project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Removal of 2021 from AWS Glo Registry

2 participants

@cmarshak @jhkennedy