fix: three unbounded sprintf() calls in cdrom_image_... in...#7133
Merged
OBattler merged 1 commit intoMay 12, 2026
Merged
Conversation
Automated security fix generated by Orbis Security AI
richardg867
added a commit
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
src/cdrom/cdrom_image_viso.c.Vulnerability
V-001src/cdrom/cdrom_image_viso.c:357Description: Three unbounded sprintf() calls in cdrom_image_viso.c write formatted output into fixed-size stack or heap buffers without specifying a maximum output length. At line 357, sprintf(tail, "~%d", i) writes into a fixed-size tail buffer where a large loop counter can overflow it. At line 492, a timestamp is formatted into a pointer p without tracking remaining buffer space. At line 806, sprintf(n, "CD-ROM %i VISO ", id + 1) writes into buffer n without size enforcement. If the formatted output exceeds the destination buffer size, adjacent memory is overwritten, corrupting stack frames or heap metadata.
Changes
src/cdrom/cdrom_image_viso.cVerification
Automated security fix by OrbisAI Security