Update hdc_st506_xt.c to try and fix seek audio not playing#6930
Merged
Conversation
hdd_audio_seek() was never called from the XT MFM controller, so seek sounds never played and #include for hdd_audio.h was missing.
also, hdd[].cur_cylinder was never updated after a seek, so
hdd_audio_seek() would always see cylinder_diff == 0 and return
rigth away
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hdd_audio_seek() was never called from the XT MFM controller, so seek sounds never played and #include for hdd_audio.h was missing.
also, hdd[].cur_cylinder was never updated after a seek, so
hdd_audio_seek() would always see cylinder_diff == 0 and return rigth away
Summary
try and fix seek audio not playing
Checklist
see #6594