qt: Fixes for removable image files #2929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es. Fix path issue when manually typing image file names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On macOS the new file dialog was forcing the use of the
.mdisuffix on files for MO disks (and likely all removable types). This PR updates the filter to allow one to specify.imgfiles for the suffix on all of the removable drive types where supported (currently: floppy, zip, mo).There was another issue where the newly-created image would appear in the incorrect place when manually typing in the filename to be used (similar to #2859 and #2868 it would just dump into
$CWD). This PR also applies the same fix for the removable image types.Checklist
References
#2859 and #2868