qt: Fix multiple issues with hdd image creation #2859
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When creating a new hdd image in qt, there were a few issues:
$CWDinstead ofusr_path. The image file would be created, but in the wrong location. As soon as the settings were confirmed the image file would then be created inusr_pathresulting in two image files.To fix:
toUInt()grabbing the calculated number. Changed the qt type tounsigned long longviatoULongLong(). Changed the size var toquint64.config.cmax settings to matchwin_settings.c.qt_harddiskdialog.cppto addusr_pathto the filename if the path is relativeNote:
config.cshould be updated to use constants formax_spt,max_hpc, etc. for each bus. I figured it would be better to add those in a separate PR.Checklist
References
N/A