Skip to content

Add OPL4-ML daughterboard emulation #2899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OBattler merged 11 commits into from
Aug 8, 2023
Merged

Add OPL4-ML daughterboard emulation #2899

OBattler merged 11 commits into from
Aug 8, 2023

Conversation

@Cacodemon345
Copy link
Contributor

@Cacodemon345 Cacodemon345 commented Nov 27, 2022 •
edited by jriwanek
Loading

Summary

Add OPL4-ML daughterboard emulation

Checklist

References

None.

@Cacodemon345 Cacodemon345 marked this pull request as draft November 29, 2022 20:23
@Cacodemon345
Copy link
Contributor Author

Cacodemon345 commented Nov 29, 2022

Marked as draft to investigate note on issues.

@Cacodemon345 Cacodemon345 marked this pull request as ready for review February 3, 2023 11:11
@Cacodemon345 Cacodemon345 marked this pull request as draft February 3, 2023 11:11
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 1, 2023
View reviewed changes
src/sound/midi_opl4.c
/* Determine the number of voices and voice parameters */
const YRW801_REGION_DATA *region = region_ptr[midi_channel->instrument & 0x7F].regions;

while (i < region_ptr[midi_channel->instrument & 0x7F].count) {

Check failure

Code scanning / CodeQL

Comparison of narrow type with wide type in loop condition

Comparison between [i](1) of type uint8_t and [count](2) of wider type int.
@OBattler OBattler changed the base branch from master to version/4.1 August 8, 2023 22:37
@OBattler OBattler marked this pull request as ready for review August 8, 2023 22:38
@OBattler OBattler merged commit 2b90cf0 into 86Box:version/4.1 Aug 8, 2023
Cacodemon345 added a commit to Cacodemon345/86Box that referenced this pull request Feb 13, 2024
@Cacodemon345
Revert "Merge pull request 86Box#2899 from Cacodemon345/opl4-daughter…
83500a4 
…board"

This reverts commit 2b90cf0, reversing
changes made to 56a8e45.

This is broken in its current state and needs to be redone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Cacodemon345 @OBattler @jriwanek