Skip to content

Show version correctly#90

Merged
5ouma merged 2 commits intomainfrom
fix-ver
May 10, 2024
Merged

Show version correctly#90
5ouma merged 2 commits intomainfrom
fix-ver

Conversation

@5ouma
Copy link
Owner

@5ouma 5ouma commented May 10, 2024

⚠️ Issue

close #35


✔︎ Checklists

  • This Pull Request introduces a new feature.
  • This Pull Request fixes a bug.

🔄 Type of the Change

  • 🎉 Feature
  • 🧰 Bug
  • 🛡️ Security
  • 📖 Documentation
  • 🧹 Refactoring
  • 🧪 Testing
  • 🔧 Maintenance
  • 🎽 CI
  • ⛓️ Dependencies
  • 🧠 Meta

✏️ Description

  1. Install via Homebrew built by GoReleaser: Show only version
  2. Install via Go Install with tagged version: Show only version
  3. Install via Go Install with branch name: Show previous version and commit hash
  4. Other: Show "unknown"

5ouma added 2 commits May 10, 2024 15:57
Not Git original one, but from Go official.
Split from `Version` when it's not a taged rev.
@prlabeler prlabeler bot added the Type: Bug label May 10, 2024
@5ouma 5ouma merged commit 0c76a6b into main May 10, 2024
@5ouma 5ouma deleted the fix-ver branch May 10, 2024 07:25
@github-actions github-actions bot mentioned this pull request May 10, 2024
5ouma added a commit that referenced this pull request May 10, 2024
## What's Changed
### 🧰 Bug Fixes
* Show version correctly by @5ouma in
#90
### 📖 Documentation Changes
* Update PR template and CONTIRBUTING.md by @5ouma in
#81
### 🧹 Refactoring
* Update some small points by @5ouma in
#83
### 🎽 CI
* Use GitHub App to add the label to PRs by @5ouma in
#76
* Use GitHub App to assign reviewer and assignee by @5ouma in
#78
* Not to specify macOS version by @5ouma in
#79
* Quote text instead of using `|` by @5ouma in
#80
* Quote text instead of using `|` by @5ouma in
#82
### ⛓️ Dependency Updates
* chore(deps): Bump pre-commit hook by @pre-commit-ci in
#84
* chore(deps): Bump pre-commit hook by @pre-commit-ci in
#85
* chore(deps): Bump pre-commit hook by @pre-commit-ci in
#86
* chore(deps): Bump pre-commit hook by @pre-commit-ci in
#87
* chore(deps): Bump pre-commit hook by @pre-commit-ci in
#88
* chore(deps): Bump Go version to 1.22.3 by @github-actions in
#89
@github-actions github-actions bot mentioned this pull request May 10, 2024
5ouma added a commit that referenced this pull request May 10, 2024
## What's Changed
### 🧰 Bug Fixes
* Show version correctly by @5ouma in
#90
### 📖 Documentation Changes
* Update PR template and CONTIRBUTING.md by @5ouma in
#81
### 🧹 Refactoring
* Update some small points by @5ouma in
#83
### 🎽 CI
* Use GitHub App to add the label to PRs by @5ouma in
#76
* Use GitHub App to assign reviewer and assignee by @5ouma in
#78
* Not to specify macOS version by @5ouma in
#79
* Quote text instead of using `|` by @5ouma in
#80
* Quote text instead of using `|` by @5ouma in
#82
### ⛓️ Dependency Updates
* chore(deps): Bump pre-commit hook by @pre-commit-ci in
#84
* chore(deps): Bump pre-commit hook by @pre-commit-ci in
#85
* chore(deps): Bump pre-commit hook by @pre-commit-ci in
#86
* chore(deps): Bump pre-commit hook by @pre-commit-ci in
#87
* chore(deps): Bump pre-commit hook by @pre-commit-ci in
#88
* chore(deps): Bump Go version to 1.22.3 by @github-actions in
#89
@github-actions github-actions bot mentioned this pull request May 10, 2024
5ouma added a commit that referenced this pull request May 10, 2024
## What's Changed
### 🧰 Bug Fixes
* Show version correctly by @5ouma in
#90
### 📖 Documentation Changes
* Update PR template and CONTIRBUTING.md by @5ouma in
#81
### 🧹 Refactoring
* Update some small points by @5ouma in
#83
### 🎽 CI
* Use GitHub App to add the label to PRs by @5ouma in
#76
* Use GitHub App to assign reviewer and assignee by @5ouma in
#78
* Not to specify macOS version by @5ouma in
#79
* Quote text instead of using `|` by @5ouma in
#80
* Quote text instead of using `|` by @5ouma in
#82
### ⛓️ Dependency Updates
* chore(deps): Bump pre-commit hook by @pre-commit-ci in
#84
* chore(deps): Bump pre-commit hook by @pre-commit-ci in
#85
* chore(deps): Bump pre-commit hook by @pre-commit-ci in
#86
* chore(deps): Bump pre-commit hook by @pre-commit-ci in
#87
* chore(deps): Bump pre-commit hook by @pre-commit-ci in
#88
* chore(deps): Bump Go version to 1.22.3 by @github-actions in
#89
@github-actions github-actions bot mentioned this pull request May 10, 2024
5ouma added a commit that referenced this pull request May 10, 2024
## What's Changed
### 🧰 Bug Fixes
* Show version correctly by @5ouma in
#90
### 📖 Documentation Changes
* Update PR template and CONTIRBUTING.md by @5ouma in
#81
### 🧹 Refactoring
* Update some small points by @5ouma in
#83
### 🎽 CI
* Use GitHub App to add the label to PRs by @5ouma in
#76
* Use GitHub App to assign reviewer and assignee by @5ouma in
#78
* Not to specify macOS version by @5ouma in
#79
* Quote text instead of using `|` by @5ouma in
#80
* Quote text instead of using `|` by @5ouma in
#82
### ⛓️ Dependency Updates
* chore(deps): Bump pre-commit hook by @pre-commit-ci in
#84
* chore(deps): Bump pre-commit hook by @pre-commit-ci in
#85
* chore(deps): Bump pre-commit hook by @pre-commit-ci in
#86
* chore(deps): Bump pre-commit hook by @pre-commit-ci in
#87
* chore(deps): Bump pre-commit hook by @pre-commit-ci in
#88
* chore(deps): Bump Go version to 1.22.3 by @github-actions in
#89
This was referenced May 10, 2024
@5ouma 5ouma added the 🧰 Bug A bug fix label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧰 Bug A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commit hash is not shown when installed by go install

1 participant