ci: prepare wallet-capable integration test environment#14
ci: prepare wallet-capable integration test environment#14rustaceanrob merged 3 commits into2140-dev:masterfrom
Conversation
Cargo.toml
Outdated
| capnpc = "0.25.0" | ||
|
|
||
| [dev-dependencies] | ||
| bitcoin = "0.32" |
There was a problem hiding this comment.
Not sure if this is a good crate, @Shourya742?
There was a problem hiding this comment.
This will be very painful to upgrade to 0.33.0 as the crate has changed substantially. I recommend using bitcoin_primitives if possible.
There was a problem hiding this comment.
I switched to the 0.33 beta tag of bitcoin-primitives.
|
In addition to picking a different crate, I also need to add some trivial test that uses the new methods. Marking draft. |
|
Needs rebase |
|
Needs rebase |
|
Rebased after #16. |
tests/util/bitcoin_core.rs
Outdated
| .collect() | ||
| } | ||
|
|
||
| fn display_hash_to_internal_bytes(hex: &str) -> Vec<u8> { |
There was a problem hiding this comment.
internals has a BlockHash type that should deal with the display vs. internal nonsense, but this is fine for now.
tests/util/bitcoin_core.rs
Outdated
|
|
||
| fn bitcoin_rpc_owned(wallet: Option<&str>, args: &[String]) -> Result<String, String> { | ||
| let mut command = Command::new(bitcoin_bin()); | ||
| command.arg("rpc").arg("-regtest").arg("-rpcwait"); |
There was a problem hiding this comment.
Same -chain=regtest thing here. Hit a panic in when testing.
Having an insufficient funds error on my end. Is the |
No, the test framework should add more funds. Let me check that. |
Also rebased (though the README change didn't cause a conflict). |
|
Still getting insufficient funds on my end, but I am on a recent commit of ACK f3f7319 |
|
Ok, we'll triage that some other time if others run into it. |
This PR prepares for #11 which needs a mempool.