Add getTransactionsByTxID() and getTransactionsByWitnessID()#11
Draft
Sjors wants to merge 2 commits into2140-dev:masterfrom
Draft
Add getTransactionsByTxID() and getTransactionsByWitnessID()#11Sjors wants to merge 2 commits into2140-dev:masterfrom
Sjors wants to merge 2 commits into2140-dev:masterfrom
Conversation
210007c to
b15d4e9
Compare
Collaborator
Author
|
@rustaceanrob can you trigger a CI run? |
b15d4e9 to
c89092d
Compare
Collaborator
Author
c89092d to
774dc9f
Compare
Collaborator
Author
|
Rebased after #9. |
Collaborator
|
Needs rebase |
774dc9f to
7107ace
Compare
Collaborator
Author
7107ace to
fac93e4
Compare
Add Mining interface methods getTransactionsByTxID and getTransactionsByWitnessID to the capnp schema. Expand integration tests to call both methods with empty inputs, a real mempool transaction id and witness id, and unknown ids, verifying serialized transaction bytes for hits and empty results for misses.
fac93e4 to
c98e1b9
Compare
Collaborator
Author
|
Rebased now that #14 landed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
getTransactionsByTxID()andgetTransactionsByWitnessID()which are introduced by bitcoin/bitcoin#34020.To be merged after: