Skip to content

Allow Symfony 7#436

Merged
bytehead merged 17 commits into1up-lab:masterfrom
evertharmeling:sf-7
Feb 5, 2024
Merged

Allow Symfony 7#436
bytehead merged 17 commits into1up-lab:masterfrom
evertharmeling:sf-7

Conversation

@evertharmeling
Copy link
Copy Markdown
Contributor

@evertharmeling evertharmeling commented Nov 28, 2023

Follows #435

Johan Kasselman and others added 12 commits August 4, 2023 10:03
1. Implemented the AsCommand attributes for final $defaultName
eb0cdf7 
2. Removed support for PHP <8.0
3. Reworked the __construct methods to be on-par with php >=8.0
4. Removed all rferences to GetMasterRequest - using only getMainRequest now
5. Fixed custom_uploader.md documentation to use getMainRequest
Changed the ci.yml fot gihub actions
9cda6c3
Ran php cs fixer for code style
32f19d9 
Reran testes, all passes
Updated php_cs_fixer to v4
2b60727 
Changed the config file to work with the new version
Ran php_cs_fixer on codebase
Tests still pass
Updated php_stan and config file
aab411e
Updated php unit-brdge to v6.0.*
3676cb5
Add tyope hint var comment/Annotation to the $helper class
8651acb
Fixe some more phpstan issues with regards to type hints and retur types
becf98d
Some mroe php cs fixer changes
6cf9f3a
@evertharmeling
Removed unused sensio/framework-extra-bundle + updated symfony/phpuni…
51ce4b4 
…t-bridge version constraint
@evertharmeling
Allow Symfony 7
f8f2f31
@evertharmeling
Updated CI to test SF 6.2 - 7.0
de49885
@evertharmeling evertharmeling mentioned this pull request Nov 28, 2023
Closed
@evertharmeling
Copy link
Copy Markdown
Contributor Author

evertharmeling commented Nov 28, 2023 •
edited
Loading

Hmm looks like with fixing the phpstan errors it introduced php-cs-fixer errors...? Alternative would probably be to not add phpdoc but direct (return) types, but that would definitely require a new major release as it would not be BC.

@bytehead
Copy link
Copy Markdown
Member

bytehead commented Nov 28, 2023

We will do a new major anyway to drop PHP 7 support and clean up a little bit 👍

@evertharmeling evertharmeling force-pushed the sf-7 branch 3 times, most recently from 5eb1752 to 1746275 Compare November 29, 2023 08:54
@evertharmeling
Copy link
Copy Markdown
Contributor Author

evertharmeling commented Nov 29, 2023 •
edited
Loading

CI runs for Symfony 6.4/7.0 should be running when new versions are released (probably in a few days hours :)), or we should refactor the used 'stability'.

Not sure how to fix the error in the lowest run...

@bytehead
Copy link
Copy Markdown
Member

bytehead commented Nov 29, 2023

Not sure how to fix the error in the lowest run...

Seems like the phpunit-brige is somewhat not compatible with the doctrine libs...

@evertharmeling
Copy link
Copy Markdown
Contributor Author

evertharmeling commented Nov 29, 2023

Found what triggered it, https://github.com/symfony/phpunit-bridge/blob/v6.0.0/bootstrap.php#L33

Which is fixed in v6.0.17 (https://github.com/symfony/phpunit-bridge/blob/v6.0.17/bootstrap.php#L33)

So added a conflict to skip versions before 6.0.17.

bytehead
bytehead requested changes Nov 29, 2023
View reviewed changes
ndench
ndench reviewed Jan 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ndench ndench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

bytehead
bytehead requested changes Jan 15, 2024
View reviewed changes
@bytehead
Copy link
Copy Markdown
Member

bytehead commented Jan 15, 2024

The pipline error seems somewhat unrelated...

@evertharmeling
Copy link
Copy Markdown
Contributor Author

evertharmeling commented Jan 15, 2024

The pipline error seems somewhat unrelated...

Yes, it's a weird one...

bytehead
bytehead requested changes Jan 15, 2024
View reviewed changes
bytehead
bytehead approved these changes Jan 15, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@bytehead bytehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you big times 🙏 🥳

@bytehead bytehead added this to the 5.x milestone Jan 15, 2024
@bytehead bytehead merged commit 594def5 into 1up-lab:master Feb 5, 2024
@bytehead bytehead mentioned this pull request Feb 5, 2024
Closed
@bytehead bytehead mentioned this pull request Mar 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bytehead bytehead bytehead approved these changes

+1 more reviewer

@ndench ndench ndench left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bc-break enhancement

Projects

None yet

Milestone

5.x

Development

Successfully merging this pull request may close these issues.

3 participants

@evertharmeling @bytehead @ndench