Fixed various deprecation fixes for Symfony >6.1, some code changes for PHP >= 8.0#435
Conversation
2. Removed support for PHP <8.0 3. Reworked the __construct methods to be on-par with php >=8.0 4. Removed all rferences to GetMasterRequest - using only getMainRequest now 5. Fixed custom_uploader.md documentation to use getMainRequest
Reran testes, all passes
Changed the config file to work with the new version Ran php_cs_fixer on codebase Tests still pass
|
There are some issues I am trying to solve here. I have not got lots of knowledge with the github actions and the actions it runs. Thanks |
|
Wait: Here is codebase that has all the above fixed already. |
|
Yes, that's the code from #432 (but closed unfortunately). I'll have look at yours 👍 |
|
Let me know what is needed here. Thanks |
|
Any update on this PR? As Symfony 7 is released shortly (end nov 2023) it would be nice to have this going forward and add support for Symfony 7. If there's any help needed, let me know. EDIT: I've created a fork based on this PR and added support for Symfony 7 in a |
|
With Symfony 6.4 and 7.0 in plain sight, any chance this will be merged any time soon? |
|
@evertharmeling can you make a PR from your branch to this PR? |
|
Not sure how I could add it to this PR, but made a new one #436 |
|
Closing this in favor of #436 (your precious work is included in there, thank you very much @joesenova!) |
We might need to bump the major package version due to dropping php v7 support with these changes