First pass at Python implementation#25
Closed
adriangb wants to merge 6 commits into1Password:mainfrom
Closed
Conversation
Contributor
|
Thanks for your work on this. Since this is still a draft PR, and it's been stale for a while, I'm closing it. If you want to resume work on this, feel free to open this PR again. FYI, we'll probably incorporate your changes into an eventual complete Python implementation. Again, thanks for the work you've done 😄 |
Contributor
Author
|
No worries. I'm terribly sorry to have started this and then let it languish. |
hculea
added a commit
to hculea/typeshare
that referenced
this pull request
Apr 30, 2024
Thanks to the prior work of @adriangb: 1Password#25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todo:
Make ordering of globals deterministic (the generated globals are not consistently ordered, which obviously makes tests fail)Done