Skip to content

Conversation

@HynoR
Copy link
Contributor

@HynoR HynoR commented Oct 24, 2025

What this PR does / why we need it?

#10747

Summary of your change

由于RemoveDirective已经被大量使用,在原函数上做修改可能会有意料之外的问题。而且大部分 directive 一般都是一个 key 一个 param,并且大部分只会在一个块出现一次, 默认这样匹配效率高。
于是另起一个扩展函数RemoveDirectiveByFullParams,对于目前和以后含表达式类且可能会在一个块内出现多次的directive,使用这个函数直接检查全部参数匹配来移除。

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 24, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ssongliu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhengkunwang223
Copy link
Member

感谢支持

@zhengkunwang223 zhengkunwang223 merged commit 21e0808 into 1Panel-dev:dev-v2 Oct 24, 2025
0 of 3 checks passed
HynoR added a commit to HynoR/1Panel that referenced this pull request Oct 24, 2025
@HynoR HynoR deleted the fix/v3 branch November 6, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants