Merged
Conversation
The HEExTokenizer is crashing when TailWindFormatter is used with a more recent version of LiveView because HEExTokenizer got out of sync with the other code in LiveView it depends on. The best solution is to ask the LiveView team to make HTMLFormatter.tokenize/1 a public function. In the meantime, vendoring everything else that HEExTokenizer needs fixes the issue.
aptinio
added a commit
to aptinio/phoenix_live_view
that referenced
this pull request
Apr 29, 2025
Currently, TailwindFormatter vendors [HTMLFormatter, Tokenizer and HTMLEngine](100phlecs/tailwind_formatter#35). It would be convenient for TailwindFormatter to use `HTMLFormatter.tokenize/1` directly and stay in sync with PhoenixLiveView.
aptinio
added a commit
to aptinio/phoenix_live_view
that referenced
this pull request
Apr 29, 2025
Currently, [TailwindFormatter vendors HTMLFormatter, Tokenizer and HTMLEngine](100phlecs/tailwind_formatter#35). It would be convenient for TailwindFormatter to use `HTMLFormatter.tokenize/1` directly and stay in sync with PhoenixLiveView.
This was referenced Apr 29, 2025
aptinio
added a commit
to aptinio/phoenix_live_view
that referenced
this pull request
Apr 29, 2025
Currently, [TailwindFormatter vendors HTMLFormatter, Tokenizer and HTMLEngine](100phlecs/tailwind_formatter#35). It would be convenient for TailwindFormatter to use `HTMLFormatter.tokenize/1` directly and stay in sync with PhoenixLiveView.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HEExTokenizer is crashing when TailWindFormatter is used with a more recent version of LiveView because HEExTokenizer got out of sync with the other code in LiveView it depends on.
The best solution is to ask the LiveView team to make
HTMLFormatter.tokenize/1a public function.In the meantime, vendoring everything else that HEExTokenizer needs fixes the issue.