Merged
Conversation
FabijanC
commented
Oct 17, 2024
10 tasks
marioiordanov
approved these changes
Oct 21, 2024
FabijanC
commented
Oct 21, 2024
Comment on lines
+1210
to
+1213
| .map_err(|e| Error::ContractExecutionErrorInSimulation { | ||
| failure_index: tx_i as u64, | ||
| error_stack: gen_tx_execution_error_trace(&e), | ||
| })?; |
Contributor
Author
There was a problem hiding this comment.
As per the specification of starknet_simulateTransactions, we shouldn't return the error right away, but include the error details in the trace of the result. Shall be taken care of in #628.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage related changes
Development related changes
stack_trace.rsfrom blockifier. Can be replaced with importing once included in an official blockifier release.Checklist:
./scripts/format.sh./scripts/clippy_check.sh./scripts/check_unused_deps.sh./scripts/check_spelling.sh./website/README.md