Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

fix: return input in depth-chart#307

Merged
dekz merged 1 commit intomasterfrom
fix/depth-chart/return-input
Aug 4, 2020
Merged

fix: return input in depth-chart#307
dekz merged 1 commit intomasterfrom
fix/depth-chart/return-input

Conversation

@dekz
Copy link
Copy Markdown
Member

@dekz dekz commented Aug 4, 2020

Returns the input values rather than the output values. This is better aligned with the way it is to be used.

For example, sell BAL, buy DAI, it returns the price and the amount of BAL that can be sold at that price.
You can take that amount and perform a swap quote either selling or buying the amount returned..

Previous it returned the amount of DAI available at that price.

Description

Testing Instructions

Checklist

  • Update documentation as needed. Website Documentation PR:
  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.

@dekz dekz requested a review from johnrjj August 4, 2020 11:31
@dekz dekz force-pushed the fix/depth-chart/return-input branch from 5e8ad93 to 79fc996 Compare August 4, 2020 11:31
@dekz
Copy link
Copy Markdown
Member Author

dekz commented Aug 4, 2020

deploy production

@dekz dekz merged commit a3fa961 into master Aug 4, 2020
@dekz dekz deleted the fix/depth-chart/return-input branch August 4, 2020 11:46
github-actions bot pushed a commit that referenced this pull request Aug 10, 2020
# [1.14.0](v1.13.0...v1.14.0) (2020-08-10)

### Bug Fixes

* handle addresses in depth ([#313](#313)) ([ce6978b](ce6978b))
* return input in depth-chart ([#307](#307)) ([a3fa961](a3fa961))
* source regression ([#306](#306)) ([cdcfc78](cdcfc78))
* update asset-swapper optimizer for splits ([#311](#311)) ([5b212c9](5b212c9))

### Features

* Add support for buy token affiliate fees ([#310](#310)) ([2866253](2866253))
* ethToInputRate cost routing ([#315](#315)) ([e542c98](e542c98))
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant