Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

fix: WETH wrap gas estimate#256

Merged
dekz merged 1 commit intomasterfrom
fix/weth-wrap-gas-limit
Jun 15, 2020
Merged

fix: WETH wrap gas estimate#256
dekz merged 1 commit intomasterfrom
fix/weth-wrap-gas-limit

Conversation

@dekz
Copy link
Copy Markdown
Member

@dekz dekz commented Jun 15, 2020

Description

40k pretty low, perhaps 40-42k if one already has WETH and is topping up a non-0 balance.

Testing Instructions

Checklist

  • Update documentation as needed. Website Documentation PR:
  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.

@dekz dekz requested a review from kimpers June 15, 2020 21:17
@dekz dekz merged commit f07b4a8 into master Jun 15, 2020
@dekz dekz deleted the fix/weth-wrap-gas-limit branch June 15, 2020 21:20
@dekz
Copy link
Copy Markdown
Member Author

dekz commented Jun 15, 2020

deploy production

github-actions bot pushed a commit that referenced this pull request Jun 22, 2020
# [1.9.0](v1.8.0...v1.9.0) (2020-06-22)

### Bug Fixes

* asset swapper monorepo f14b6f2ba ([#257](#257)) ([a03630a](a03630a))
* Disable quote validation temporarily ([#259](#259)) ([6064f3e](6064f3e))
* filter tokens in prices which do not exist on the network ([#265](#265)) ([864ea92](864ea92))
* Fix parameters sent off to RFQT providers to be unescaped ([#264](#264)) ([939cae1](939cae1))
* validation gas limit ([#260](#260)) ([f50425c](f50425c)), closes [#259](#259)
* WETH wrap gas estimate ([#256](#256)) ([f07b4a8](f07b4a8))

### Features

* add signer liveness status gauge ([#255](#255)) ([11446e7](11446e7))
* support renamed parameters in RFQT maker endpoint ([#258](#258)) ([d83bbb1](d83bbb1))
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant