This repository was archived by the owner on Oct 15, 2024. It is now read-only.
feat: Add support for buy token affiliate fees#310
Merged
moodlezoup merged 2 commits intomasterfrom Aug 7, 2020
Merged
Conversation
moodlezoup
commented
Aug 6, 2020
fbdfcd9 to
343123f
Compare
dekz
reviewed
Aug 6, 2020
Member
dekz
left a comment
There was a problem hiding this comment.
Lookin good to me, one question about the way the new buyAmount is scaled.
Contributor
Author
|
deploy staging |
7e87547 to
796c89c
Compare
Contributor
Author
|
deploy staging |
796c89c to
5acb974
Compare
dorothy-zbornak
approved these changes
Aug 7, 2020
Contributor
dorothy-zbornak
left a comment
There was a problem hiding this comment.
🙌 Thanks again for taking this on.
| } else if (buyAmount !== undefined) { | ||
| const buyAmountScaled = buyAmount | ||
| .times(affiliateFee.buyTokenPercentageFee + 1) | ||
| .integerValue(BigNumber.ROUND_DOWN); |
Contributor
There was a problem hiding this comment.
I feel like this should be ROUND_UP.
Contributor
Author
There was a problem hiding this comment.
I believe the rounding mode needs to be the same between this and getAffiliateFeeAmounts
Contributor
There was a problem hiding this comment.
Isn't it possible we'll be under by 1 wei after the affiliate fee is taken out by the transformer?
Contributor
Author
There was a problem hiding this comment.
I tried to work out the math but gave up
for (let i = 0; i < 100000; i++) {
it(`Test ${i}`, () => {
const buyAmount = getRandomInteger(0, constants.ONE_ETHER);
const buyTokenPercentageFee = getRandomFloat(0, 1);
const buyAmountScaled = buyAmount.times(buyTokenPercentageFee.plus(1)).integerValue(BigNumber.ROUND_DOWN);
const buyTokenFeeAmount = buyAmountScaled
.times(buyTokenPercentageFee)
.dividedBy(buyTokenPercentageFee.plus(1))
.integerValue(BigNumber.ROUND_DOWN);
expect(buyAmountScaled.minus(buyTokenFeeAmount)).to.bignumber.equal(buyAmount);
});
}
100000 passing (26s)
Comment on lines
+212
to
+215
| const buyTokenFeeAmount = quote.worstCaseQuoteInfo.makerAssetAmount | ||
| .times(fee.buyTokenPercentageFee) | ||
| .dividedBy(fee.buyTokenPercentageFee + 1) | ||
| .integerValue(BigNumber.ROUND_DOWN); |
Contributor
There was a problem hiding this comment.
I like that the the fee is only off the guaranteed price.
Contributor
Author
|
deploy staging |
5acb974 to
675965a
Compare
Contributor
Author
|
deploy production |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 10, 2020
# [1.14.0](v1.13.0...v1.14.0) (2020-08-10) ### Bug Fixes * handle addresses in depth ([#313](#313)) ([ce6978b](ce6978b)) * return input in depth-chart ([#307](#307)) ([a3fa961](a3fa961)) * source regression ([#306](#306)) ([cdcfc78](cdcfc78)) * update asset-swapper optimizer for splits ([#311](#311)) ([5b212c9](5b212c9)) ### Features * Add support for buy token affiliate fees ([#310](#310)) ([2866253](2866253)) * ethToInputRate cost routing ([#315](#315)) ([e542c98](e542c98))
|
🎉 This PR is included in version 1.14.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing Instructions
Checklist
[WIP]if necessary.