Skip to content

eth: fix overflow impacting milestone lock and syncing#2111

Merged
marcello33 merged 3 commits intodevelopfrom
mardizzone/issue_66
Mar 5, 2026
Merged

eth: fix overflow impacting milestone lock and syncing#2111
marcello33 merged 3 commits intodevelopfrom
mardizzone/issue_66

Conversation

@marcello33
Copy link
Copy Markdown
Collaborator

Description

Fixes issue 66.

@marcello33 marcello33 requested a review from a team March 5, 2026 10:51
@lucca30
Copy link
Copy Markdown
Contributor

lucca30 commented Mar 5, 2026

@claude Do a careful review on this PR. Looking for any potential bug introduced by the changes or vulnerabilities. Also classify if this PR is a high, medium or low risk change in terms of how much time we need to test it before feel safe to trust it.

Check if the tests are aligned with what the fix is proposed for and if the fix address the issue it wants to fix.

@claude
Copy link
Copy Markdown

claude bot commented Mar 5, 2026

Claude encountered an error —— View job


I'll analyze this and get back to you.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.44%. Comparing base (a26743d) to head (ad0bae3).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
eth/bor_api_backend.go 60.00% 4 Missing ⚠️
eth/downloader/whitelist/service.go 70.00% 2 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (65.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2111      +/-   ##
===========================================
- Coverage    51.44%   51.44%   -0.01%     
===========================================
  Files          881      881              
  Lines       153821   153835      +14     
===========================================
- Hits         79139    79134       -5     
- Misses       69506    69520      +14     
- Partials      5176     5181       +5     
Files with missing lines Coverage Δ
eth/downloader/whitelist/service.go 91.98% <70.00%> (-0.80%) ⬇️
eth/bor_api_backend.go 26.25% <60.00%> (+7.82%) ⬆️

... and 16 files with indirect coverage changes

Files with missing lines Coverage Δ
eth/downloader/whitelist/service.go 91.98% <70.00%> (-0.80%) ⬇️
eth/bor_api_backend.go 26.25% <60.00%> (+7.82%) ⬆️

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 5, 2026

@marcello33 marcello33 merged commit 27130c2 into develop Mar 5, 2026
18 of 21 checks passed
lucca30 pushed a commit that referenced this pull request Mar 5, 2026
* eth: fix overflow impacting milestone lock and syncing

* eth: address comments

(cherry picked from commit 27130c2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants