Skip to content

metrics: add more go runtime metrics#2109

Merged
manav2401 merged 1 commit intodevelopfrom
manav/sys-metrics
Mar 5, 2026
Merged

metrics: add more go runtime metrics#2109
manav2401 merged 1 commit intodevelopfrom
manav/sys-metrics

Conversation

@manav2401
Copy link
Copy Markdown
Member

@manav2401 manav2401 commented Mar 5, 2026

Description

Add new metrics from go runtime related to Garbage Collection and CPU usage for GC.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 5, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 38.70968% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.39%. Comparing base (5f5ec38) to head (be7ac50).
⚠️ Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
metrics/metrics.go 38.70% 38 Missing ⚠️

❌ Your patch status has failed because the patch coverage (38.70%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2109      +/-   ##
===========================================
+ Coverage    51.20%   51.39%   +0.19%     
===========================================
  Files          878      881       +3     
  Lines       152499   152852     +353     
===========================================
+ Hits         78081    78557     +476     
+ Misses       69315    69193     -122     
+ Partials      5103     5102       -1
Files with missing lines Coverage Δ
metrics/metrics.go 25.80% <38.70%> (+4.59%) ⬆️

... and 50 files with indirect coverage changes

Files with missing lines Coverage Δ
metrics/metrics.go 25.80% <38.70%> (+4.59%) ⬆️

... and 50 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@manav2401 manav2401 merged commit a26743d into develop Mar 5, 2026
20 of 22 checks passed
@manav2401 manav2401 deleted the manav/sys-metrics branch March 5, 2026 10:32
manav2401 added a commit that referenced this pull request Mar 9, 2026
@manav2401
metrics: add more go runtime metrics (#2109)
0504ecd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcello33 marcello33 marcello33 approved these changes

@pratikspatil024 pratikspatil024 pratikspatil024 approved these changes

@kamuikatsurgi kamuikatsurgi kamuikatsurgi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@manav2401 @marcello33 @pratikspatil024 @kamuikatsurgi