core/stateless: fix witness RLP backward compat with WIT/0 peers#2068
Merged
core/stateless: fix witness RLP backward compat with WIT/0 peers#2068
Conversation
Nodes upgraded from WIT/0 to WIT/1 were incorrectly jailing WIT/0 peers with "rlp: too few elements for stateless.ExtWitness". A 5-field ExtWitness encoding (Context, Headers, Codes, State, Keys) was accidentally introduced during an upstream geth merge, replacing the original 3-field wire format (Context, Headers, State) that WIT/0 peers still use. Introduce BorWitness as the canonical 3-field wire format. EncodeRLP now encodes using BorWitness (State only, codes excluded). DecodeRLP tries BorWitness first and falls back to ExtWitness for backward compatibility with peers that temporarily ran the extended encoding. ExtWitness is retained as the representation for the JSON debug API (ExecutionWitness, ExecutionWitnessByHash) and as the fallback decode target for the transitional period.
|
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (85.18%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #2068 +/- ##
==========================================
+ Coverage 49.60% 49.61% +0.01%
==========================================
Files 873 873
Lines 150616 150641 +25
==========================================
+ Hits 74715 74746 +31
+ Misses 70841 70834 -7
- Partials 5060 5061 +1
... and 14 files with indirect coverage changes
🚀 New features to boost your workflow:
|
marcello33
approved these changes
Feb 19, 2026
manav2401
approved these changes
Feb 19, 2026
manav2401
added a commit
that referenced
this pull request
Feb 20, 2026
…) (#2072) * core/stateless: fix witness RLP backward compat with WIT/0 peers Nodes upgraded from WIT/0 to WIT/1 were incorrectly jailing WIT/0 peers with "rlp: too few elements for stateless.ExtWitness". A 5-field ExtWitness encoding (Context, Headers, Codes, State, Keys) was accidentally introduced during an upstream geth merge, replacing the original 3-field wire format (Context, Headers, State) that WIT/0 peers still use. Introduce BorWitness as the canonical 3-field wire format. EncodeRLP now encodes using BorWitness (State only, codes excluded). DecodeRLP tries BorWitness first and falls back to ExtWitness for backward compatibility with peers that temporarily ran the extended encoding. ExtWitness is retained as the representation for the JSON debug API (ExecutionWitness, ExecutionWitnessByHash) and as the fallback decode target for the transitional period. * Add test Co-authored-by: Jerry <jerrycgh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nodes upgraded from WIT/0 to WIT/1 were incorrectly jailing WIT/0 peers with "rlp: too few elements for stateless.ExtWitness". A 5-field ExtWitness encoding (Context, Headers, Codes, State, Keys) was accidentally introduced during an upstream geth merge, replacing the original 3-field wire format (Context, Headers, State) that WIT/0 peers still use.
Introduce BorWitness as the canonical 3-field wire format. EncodeRLP now encodes using BorWitness (State only, codes excluded). DecodeRLP tries BorWitness first and falls back to ExtWitness for backward compatibility with peers that temporarily ran the extended encoding.
ExtWitness is retained as the representation for the JSON debug API (ExecutionWitness, ExecutionWitnessByHash) and as the fallback decode target for the transitional period.