Clean up lastRebroadcast on transaction rejection#2038
Merged
kamuikatsurgi merged 2 commits into0xPolygon:developfrom Feb 26, 2026
Merged
Clean up lastRebroadcast on transaction rejection#2038kamuikatsurgi merged 2 commits into0xPolygon:developfrom
kamuikatsurgi merged 2 commits into0xPolygon:developfrom
Conversation
1bdb40c to
72a78a3
Compare
Contributor
|
Thanks for the fix! Could you rebase on top of |
72a78a3 to
e2bd018
Compare
|
kamuikatsurgi
approved these changes
Feb 26, 2026
Contributor
|
@claude Can you analyze the changes. Deep looking if there is any security breach introduced, check if the changes helps or somehow that can potentially lead to any bug? |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
lucca30
approved these changes
Feb 26, 2026
lucca30
pushed a commit
that referenced
this pull request
Mar 5, 2026
* Clean up lastRebroadcast on transaction rejection * Add test for lastRebroadcast cleanup on promotion rejection (cherry picked from commit fdbc857)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes transaction hash from lastRebroadcast map when rejected during promotion, preventing memory accumulation.