Dandeli HF: modify block gas target calculations by manav2401 · Pull Request #1968 · 0xPolygon/bor

manav2401 · 2026-01-06T11:00:30Z

Description

Instead of deriving block gas target to calculate base fee for eip 1559 using elasticity multiplier, this HF introduces a percentage denoting the percent of gas target to choose from total block gas limit. It acts as an inverse of elasticity multiplier in percent terms. E.g. current default elasticity multiplier is 2 which translates to 50% of total block limit as gas target. To address the gas spikes, this is modified to 66% which means gas target would be 66% of block gas limit. This makes the base fee increase bit slower that earlier during surge in chain activity.

Changes

Bugfix (non-breaking change that solves an issue)
Hotfix (change that solves an urgent issue, and requires immediate attention)
New feature (non-breaking change that adds functionality)
Breaking change (change that is not backwards-compatible and/or changes current functionality)
Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

I have added at least 2 reviewer or the whole pos-v1 team
I have added sufficient documentation in code
I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

This PR requires changes to heimdall
- In case link the PR here:
This PR requires changes to matic-cli
- In case link the PR here:

Testing

I have added unit tests
I have added tests to CI
I have tested this code manually on local environment
I have tested this code manually on remote devnet using express-cli
I have tested this code manually on amoy
I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

params/protocol_params.go

consensus/misc/eip1559/eip1559.go

codecov · 2026-01-06T16:41:35Z

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (v2.5.6-candidate@b383ab1). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
params/config.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##             v2.5.6-candidate    #1968   +/-   ##
===================================================
  Coverage                    ?   47.94%           
===================================================
  Files                       ?      844           
  Lines                       ?   144191           
  Branches                    ?        0           
===================================================
  Hits                        ?    69137           
  Misses                      ?    70526           
  Partials                    ?     4528

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cffls · 2026-01-06T17:03:25Z

There is a linter error, otherwise looks good to me

sonarqubecloud · 2026-01-06T17:31:37Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.8% Duplication on New Code

See analysis details on SonarQube Cloud

* bump version * Revert "V2.5.6 candidate (#1941)" This reverts commit 85b5ef7. * fix: ignore invalid signer error for specific block range (#1944) * bump version * stable version * V2.5.6 candidate (#1941) * Revert recorded write operations when tx fails * Revert selfdestruct on failure * Added test for selfdestruct revert write * Add HasSelfDestructed check when applying to final db * p2p: added functionality to temporarily ban peers to prevent connections (#1922) * p2p: added functionality to temporarily ban peers to prevent connections * p2p: cleanup * chore: bump kurtosis-pos (#1923) * chore: bump kurtosis-pos * chore: nits * chore: install go * fix(miner): delete pending task after successful block sealing to prevent node stall (#1929) * fix(miner): delete pending task after successful block sealing to prevent node stall * chore: nits * chore: set staleThreshold to 0 * chore: update comment * Remove Recommit and Fix Parent Actual Time track on Prepare (#1938) * remove recommit and track parent actual time * applying pr comments * fix actual time cache store place * chore: update deps (#1939) chore: update deps * bump version * bump version * stable version --------- Co-authored-by: Angel Valkov <avalkov@polygon.technology> Co-authored-by: Marcello Ardizzone <marcelloardizzone@hotmail.it> Co-authored-by: Pratik Patil <pratikspatil024@gmail.com> Co-authored-by: Krishang <109511742+kamuikatsurgi@users.noreply.github.com> Co-authored-by: kamuikatsurgi <shahkrishang11@gmail.com> * Unstuck * Added block range check * bump version 2.5.7 * bump to 2.5.6-beta3 --------- Co-authored-by: Lucca Martins <lucca_martins30@yahoo.com.br> Co-authored-by: Marcello Ardizzone <marcelloardizzone@hotmail.it> Co-authored-by: Pratik Patil <pratikspatil024@gmail.com> Co-authored-by: Krishang <109511742+kamuikatsurgi@users.noreply.github.com> Co-authored-by: kamuikatsurgi <shahkrishang11@gmail.com> * fix(miner): track pending work using block number to avoid duplicate block building work (#1943) * bump version * stable version * V2.5.6 candidate (#1941) * Revert recorded write operations when tx fails * Revert selfdestruct on failure * Added test for selfdestruct revert write * Add HasSelfDestructed check when applying to final db * p2p: added functionality to temporarily ban peers to prevent connections (#1922) * p2p: added functionality to temporarily ban peers to prevent connections * p2p: cleanup * chore: bump kurtosis-pos (#1923) * chore: bump kurtosis-pos * chore: nits * chore: install go * fix(miner): delete pending task after successful block sealing to prevent node stall (#1929) * fix(miner): delete pending task after successful block sealing to prevent node stall * chore: nits * chore: set staleThreshold to 0 * chore: update comment * Remove Recommit and Fix Parent Actual Time track on Prepare (#1938) * remove recommit and track parent actual time * applying pr comments * fix actual time cache store place * chore: update deps (#1939) chore: update deps * bump version * bump version * stable version --------- Co-authored-by: Angel Valkov <avalkov@polygon.technology> Co-authored-by: Marcello Ardizzone <marcelloardizzone@hotmail.it> Co-authored-by: Pratik Patil <pratikspatil024@gmail.com> Co-authored-by: Krishang <109511742+kamuikatsurgi@users.noreply.github.com> Co-authored-by: kamuikatsurgi <shahkrishang11@gmail.com> * fix: add pendingWorkBlock to prevent duplicate work * fix: if check * nit: comment * chore: bump version * chore: add pending work check in new head event as well * chore: read veblop timeout --------- Co-authored-by: Lucca Martins <lucca_martins30@yahoo.com.br> Co-authored-by: Angel Valkov <avalkov@polygon.technology> Co-authored-by: Marcello Ardizzone <marcelloardizzone@hotmail.it> Co-authored-by: Pratik Patil <pratikspatil024@gmail.com> * chore: bump version to v2.5.6-beta4 * fix(rpc): maxFeePerGas and maxPriorityFeePerGas for StateSyncTx type (#1952) * Fix missing chain validator service setup (#1957) * eth/protocols/wit: made protocol version consistent (#1940) * eth: add missing checker initialization * core: add log when verifyPendingHeaders is skipped * Revert "eth/protocols/wit: made protocol version consistent (#1940)" This reverts commit c98a00e. --------- Co-authored-by: Pratik Patil <pratikspatil024@gmail.com> * fix(api): traceBlock (#1959) * Revert "Merge branch 'master' into v2.5.6-candidate" This reverts commit 809b189, reversing changes made to 1dbae9d. * version bump to v2.5.6-beta5 * Dandeli HF: modify block gas target calculations (#1968) * remove baseFee validation after hf * remove logs * params, consensus: use target gas percentage for base fee calculations * cleanup * add comments * consensus/misc/eip1559: add tests for untitled HF * typo * test fixes * update HF name to dandeli * simplify * update gas target to 65%, fix tests * update comment * fix tests * fix tests * fix tests * schedule dandeli HF for amoy at block 31890000 * fix lint * add missing madhugiripro HF in amoy genesis --------- Co-authored-by: Lucca Martins <lucca_martins30@yahoo.com.br> * params: bump version to v2.5.6-beta6 * Update DandeliBlock HF for mainnet and bump version --------- Co-authored-by: Lucca Martins <lucca_martins30@yahoo.com.br> Co-authored-by: Angel Valkov <avalkov@polygon.technology> Co-authored-by: Marcello Ardizzone <marcelloardizzone@hotmail.it> Co-authored-by: Krishang <109511742+kamuikatsurgi@users.noreply.github.com> Co-authored-by: kamuikatsurgi <shahkrishang11@gmail.com> Co-authored-by: Raneet Debnath <35629432+Raneet10@users.noreply.github.com> Co-authored-by: Manav Darji <manavdarji.india@gmail.com> Co-authored-by: Jerry <jerrycgh@gmail.com>

lucca30 and others added 4 commits January 5, 2026 15:56

remove baseFee validation after hf

cf73016

remove logs

df3fb89

params, consensus: use target gas percentage for base fee calculations

6845adf

cleanup

b4330d0

manav2401 marked this pull request as ready for review January 6, 2026 11:01

manav2401 added 4 commits January 6, 2026 16:43

add comments

78a3c06

consensus/misc/eip1559: add tests for untitled HF

fe4576a

typo

7b8b86b

test fixes

3a31904

kamuikatsurgi approved these changes Jan 6, 2026

View reviewed changes

Raneet10 approved these changes Jan 6, 2026

View reviewed changes

update HF name to dandeli

44c4132

manav2401 changed the title ~~Elasticity multiplier hf~~ Dandeli HF: modify block gas target calculations Jan 6, 2026

simplify

4fdf1ee

ssandeep suggested changes Jan 6, 2026

View reviewed changes

params/protocol_params.go Outdated Show resolved Hide resolved

update gas target to 65%, fix tests

455074e

pratikspatil024 approved these changes Jan 6, 2026

View reviewed changes

params/protocol_params.go Show resolved Hide resolved

pratikspatil024 reviewed Jan 6, 2026

View reviewed changes

consensus/misc/eip1559/eip1559.go Show resolved Hide resolved

manav2401 added 4 commits January 6, 2026 20:59

update comment

8106468

fix tests

8594c54

fix tests

df4f5b6

fix tests

13ec77a

manav2401 added 3 commits January 6, 2026 22:49

schedule dandeli HF for amoy at block 31890000

335c838

fix lint

dc90771

add missing madhugiripro HF in amoy genesis

a7686ab

cffls approved these changes Jan 6, 2026

View reviewed changes

manav2401 merged commit 5c685e8 into v2.5.6-candidate Jan 6, 2026
8 checks passed

manav2401 deleted the elasticity-multiplier-hf branch January 6, 2026 17:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dandeli HF: modify block gas target calculations#1968

Dandeli HF: modify block gas target calculations#1968
manav2401 merged 18 commits intov2.5.6-candidatefrom
elasticity-multiplier-hf

manav2401 commented Jan 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jan 6, 2026

Uh oh!

cffls commented Jan 6, 2026

Uh oh!

sonarqubecloud bot commented Jan 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

manav2401 commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Breaking changes

Nodes audience

Checklist

Cross repository changes

Testing

Manual tests

Additional comments

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jan 6, 2026

Codecov Report

Uh oh!

cffls commented Jan 6, 2026

Uh oh!

sonarqubecloud bot commented Jan 6, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

manav2401 commented Jan 6, 2026 •

edited

Loading