chore: Bump NOTE_MAX_SIZE to 256 KiB#2651
Merged
mmagician merged 2 commits intorelease/v0.14.0-betafrom Mar 20, 2026
Merged
Conversation
greenhat
approved these changes
Mar 20, 2026
Collaborator
greenhat
left a comment
There was a problem hiding this comment.
LGTM! Thank you for the quick fix!
mmagician
approved these changes
Mar 20, 2026
Collaborator
mmagician
left a comment
There was a problem hiding this comment.
back and forth on the limit :)
PhilippGackstatter
added a commit
that referenced
this pull request
Mar 20, 2026
* chore: bump NOTE_MAX_SIZE to 256 KiB * chore: add changelog
Contributor
|
Let's create an issue for figuring out what to do on this front long term. We may want to bring down the limit back to 32KB - or maybe keep the 256KB limit, but make the fees associated with the note script size scale superlinearly. |
This was referenced Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the NOTE_MAX_SIZE to be equal to ACCOUNT_UPDATE_MAX_SIZE to allow compiler artifacts to be tested in current networks.
Will leave a note in #1465 to bring it down again in the future.
closes #2648