refactor: remove OutputNoteData from AdviceMap in CLAIM note#2509
Merged
refactor: remove OutputNoteData from AdviceMap in CLAIM note#2509
OutputNoteData from AdviceMap in CLAIM note#2509Conversation
mmagician
reviewed
Feb 25, 2026
mmagician
reviewed
Feb 25, 2026
Collaborator
|
I think this is the last item in #2237, right? (there is one that depends on migration to vm v0.21 but there's a TODO in the code already and it's not high priority) |
mmagician
pushed a commit
that referenced
this pull request
Mar 2, 2026
Reflect three changes since the last agglayer merge: - Sender validation moved from note scripts into bridge procedures (assert_sender_is_* are now internal, not part of public interface) - OutputNoteData removed from CLAIM AdviceMap; storage shrinks 576→569 felts; P2ID serial num and tag now derived at runtime - CLAIM consumer enforcement unified to NetworkAccountTarget attachment https://claude.ai/code/session_01AKvg8rguWHdffgHpxkVYSr
mmagician
pushed a commit
that referenced
this pull request
Mar 2, 2026
…2511) Reflect changes since the last agglayer merge: - CLAIM consumer enforcement unified to NetworkAccountTarget attachment, removing target_faucet_account_id from storage and TODO #2468 (#2480) - Sender validation moved from note scripts into bridge procedures; assert_sender_is_* are now internal, not part of public interface (#2511) - OutputNoteData removed from CLAIM AdviceMap; storage shrinks 576→569 felts; P2ID serial num and tag now derived at runtime (#2509) https://claude.ai/code/session_01AKvg8rguWHdffgHpxkVYSr
afa7789
pushed a commit
to afa7789/miden-base
that referenced
this pull request
Mar 9, 2026
…xMiden#2509) * feat: rm serial_num & output_note_tag from OutputNoteData * feat: rm OutputNoteData from AdviceMap * refactor: cleanup masm & fix pad amounts in stack comments * refactor: update number of NoteStorage values in comment * refactor: update claim_storage size and update comments * refactor: use prefix from proc input & cleanup pad stack comments * revert stack pad comment changes * fix: rm old comment * fix: correct CLAIM stack comments and flatten OutputNoteData into ClaimNoteStorage * fix: rustfmt * fix: fix stack comment pad(x) * chore: dropw -> drop is sufficient --------- Co-authored-by: Marti <marti@miden.team> Co-authored-by: mmagician <marcin.gorny.94@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
OutputNoteDatastruct by removing the output note serial number and target tag. Additionally,OutputNoteDatais removed fromAdviceMapin theCLAIMnote logic.Resolves: #2237 (comment)