Skip to content

refactor: remove OutputNoteData from AdviceMap in CLAIM note#2509

Merged
mmagician merged 15 commits intoagglayerfrom
ajl-refactor-output-note-data
Feb 25, 2026
Merged

refactor: remove OutputNoteData from AdviceMap in CLAIM note#2509
mmagician merged 15 commits intoagglayerfrom
ajl-refactor-output-note-data

Conversation

@partylikeits1983
Copy link
Copy Markdown
Member

@partylikeits1983 partylikeits1983 commented Feb 25, 2026

This PR refactors the OutputNoteData struct by removing the output note serial number and target tag. Additionally, OutputNoteData is removed from AdviceMap in the CLAIM note logic.

Resolves: #2237 (comment)

@partylikeits1983 partylikeits1983 added agglayer PRs or issues related to AggLayer bridging integration pr-from-maintainers PRs that come from internal contributors or integration partners. They should be given priority no changelog This PR does not require an entry in the `CHANGELOG.md` file labels Feb 25, 2026
@partylikeits1983 partylikeits1983 marked this pull request as ready for review February 25, 2026 09:05
Copy link
Copy Markdown
Collaborator

@mmagician mmagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mmagician
Copy link
Copy Markdown
Collaborator

I think this is the last item in #2237, right? (there is one that depends on migration to vm v0.21 but there's a TODO in the code already and it's not high priority)

@mmagician mmagician enabled auto-merge (squash) February 25, 2026 18:28
@mmagician mmagician merged commit 7fe02b6 into agglayer Feb 25, 2026
17 checks passed
@mmagician mmagician deleted the ajl-refactor-output-note-data branch February 25, 2026 18:29
mmagician pushed a commit that referenced this pull request Mar 2, 2026
Reflect three changes since the last agglayer merge:
- Sender validation moved from note scripts into bridge procedures
  (assert_sender_is_* are now internal, not part of public interface)
- OutputNoteData removed from CLAIM AdviceMap; storage shrinks 576→569
  felts; P2ID serial num and tag now derived at runtime
- CLAIM consumer enforcement unified to NetworkAccountTarget attachment

https://claude.ai/code/session_01AKvg8rguWHdffgHpxkVYSr
mmagician pushed a commit that referenced this pull request Mar 2, 2026
…2511)

Reflect changes since the last agglayer merge:
- CLAIM consumer enforcement unified to NetworkAccountTarget attachment,
  removing target_faucet_account_id from storage and TODO #2468 (#2480)
- Sender validation moved from note scripts into bridge procedures;
  assert_sender_is_* are now internal, not part of public interface (#2511)
- OutputNoteData removed from CLAIM AdviceMap; storage shrinks 576→569
  felts; P2ID serial num and tag now derived at runtime (#2509)

https://claude.ai/code/session_01AKvg8rguWHdffgHpxkVYSr
afa7789 pushed a commit to afa7789/miden-base that referenced this pull request Mar 9, 2026
…xMiden#2509)

* feat: rm serial_num & output_note_tag from OutputNoteData

* feat: rm OutputNoteData from AdviceMap

* refactor: cleanup masm & fix pad amounts in stack comments

* refactor: update number of NoteStorage values in comment

* refactor: update claim_storage size and update comments

* refactor: use prefix from proc input & cleanup pad stack comments

* revert stack pad comment changes

* fix: rm old comment

* fix: correct CLAIM stack comments and flatten OutputNoteData into ClaimNoteStorage

* fix: rustfmt

* fix: fix stack comment pad(x)

* chore: dropw -> drop is sufficient

---------

Co-authored-by: Marti <marti@miden.team>
Co-authored-by: mmagician <marcin.gorny.94@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agglayer PRs or issues related to AggLayer bridging integration no changelog This PR does not require an entry in the `CHANGELOG.md` file pr-from-maintainers PRs that come from internal contributors or integration partners. They should be given priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants