feat(standards): add NoteExecutionHint constants to MASM standards#2493
Merged
feat(standards): add NoteExecutionHint constants to MASM standards#2493
NoteExecutionHint constants to MASM standards#2493Conversation
Add `note/execution_hint.masm` under the standards library exposing the four NoteExecutionHint variants as public constants: - NONE = 0 - ALWAYS = 1 - AFTER_BLOCK = 2 (tag bits only; payload must be composed at runtime) - ON_BLOCK_SLOT = 3 (tag bits only; payload must be composed at runtime) These mirror the `NONE_TAG` / `ALWAYS_TAG` / `AFTER_BLOCK_TAG` / `ON_BLOCK_SLOT_TAG` internal constants from the Rust `NoteExecutionHint` implementation and allow MASM callers to reference them via `use miden::standards::note::execution_hint::ALWAYS` (etc.) rather than duplicating magic numbers locally. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
Author
|
@copilot add changelog entry |
Contributor
|
@mmagician I've opened a new pull request, #2496, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
docs: add changelog entry for NoteExecutionHint MASM constants
NoteExecutionHint constants to MASM standards
mmagician
commented
Feb 24, 2026
afa7789
pushed a commit
to afa7789/miden-base
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/miden-standards/asm/standards/note/execution_hint.masmexposing the fourNoteExecutionHintvariants as public MASM constants:NONE,ALWAYS,AFTER_BLOCK,ON_BLOCK_SLOT, matching the RustNoteExecutionHintimplementationAFTER_BLOCKandON_BLOCK_SLOTthe constants encode only the 8 tag bits; callers must compose the payload🤖 Generated with Claude Code