refactor(agglayer): rm P2ID output serial num from CLAIM note NoteStorage#2484
Closed
partylikeits1983 wants to merge 24 commits intoagglayerfrom
Closed
refactor(agglayer): rm P2ID output serial num from CLAIM note NoteStorage#2484partylikeits1983 wants to merge 24 commits intoagglayerfrom
P2ID output serial num from CLAIM note NoteStorage#2484partylikeits1983 wants to merge 24 commits intoagglayerfrom
Conversation
Co-authored-by: Marti <marti@miden.team>
bobbinth
reviewed
Feb 23, 2026
bobbinth
reviewed
Feb 23, 2026
|
|
||
| /// Output note data for CLAIM note creation. | ||
| /// Contains note-specific data and can use Miden types. | ||
| /// TODO: Remove all but target_faucet_account_id |
Contributor
There was a problem hiding this comment.
Not sure if we should remove this TODO just yet:
- We should be able to get rid of
output_note_tagas well - right? - Do we actually need
target_faucet_account_idhere? How is it used in the output note?
Collaborator
There was a problem hiding this comment.
Agreed we should only remove the TODO after the tag is gone (planned for a follow-up, as noted in the PR description)
Do we actually need
target_faucet_account_idhere? How is it used in the output note?
It's not used for the output note, but rather for the claim note itself. We currently use it to check that only the target faucet can consume this CLAIM note, but this will be changed to use attachments
Base automatically changed from
ajl-claim-note-quotient-notestorage
to
agglayer
February 23, 2026 15:57
04c2f25 to
5b8ef5f
Compare
Member
Author
|
Closed by: #2509 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
NoteStorageof theCLAIMnote by removing the requirement for output noteP2IDserial number. The outputP2IDserial number is now the hash of thePROOF_DATA, i.e.Hasher::hash_elements(proof_data_elements)This is already conveniently computed in MASM inside the
CLAIMnote and stored to global memory asPROOF_DATA_KEY.Partially resolves (removing tag will be in a separate PR): #2237 (comment)