refactor: replace auth event constant workarounds with direct imports#2404
Merged
PhilippGackstatter merged 3 commits into0xMiden:nextfrom Feb 5, 2026
Merged
Conversation
2444ddb to
a360602
Compare
Replace the temporary workaround constants introduced in PR 0xMiden#2377 with direct imports from `miden::protocol::auth`. The linker bug that required the workaround has been fixed in miden-vm#2637. Changes: - Replace `const AUTH_REQUEST_EVENT = ::miden::protocol::auth::AUTH_REQUEST_EVENT` with `use miden::protocol::auth::AUTH_REQUEST_EVENT` - Replace `const AUTH_UNAUTHORIZED_EVENT = ::miden::protocol::auth::AUTH_UNAUTHORIZED_EVENT` with `use miden::protocol::auth::AUTH_UNAUTHORIZED_EVENT` Closes 0xMiden#2392
a360602 to
f5c57f7
Compare
f5c57f7 to
d38823c
Compare
Contributor
Author
|
Hi @PhilippGackstatter kindly my PR needs review. please let me know if anything else we need here. |
PhilippGackstatter
approved these changes
Feb 5, 2026
Contributor
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Thank you for fixing this!
afa7789
pushed a commit
to afa7789/miden-base
that referenced
this pull request
Mar 9, 2026
…0xMiden#2404) * refactor: replace auth event constant workarounds with direct imports Replace the temporary workaround constants introduced in PR 0xMiden#2377 with direct imports from `miden::protocol::auth`. The linker bug that required the workaround has been fixed in miden-vm#2637. Changes: - Replace `const AUTH_REQUEST_EVENT = ::miden::protocol::auth::AUTH_REQUEST_EVENT` with `use miden::protocol::auth::AUTH_REQUEST_EVENT` - Replace `const AUTH_UNAUTHORIZED_EVENT = ::miden::protocol::auth::AUTH_UNAUTHORIZED_EVENT` with `use miden::protocol::auth::AUTH_UNAUTHORIZED_EVENT` Closes 0xMiden#2392 * chore: update miden-assembly to v0.20.6 for constant import support --------- Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the temporary workaround constants introduced in PR #2377 with direct imports from
miden::protocol::auth. The linker bug that required the workaround has been fixed in miden-vm#2637.Changes
const AUTH_REQUEST_EVENT = ::miden::protocol::auth::AUTH_REQUEST_EVENTwithuse miden::protocol::auth::AUTH_REQUEST_EVENTconst AUTH_UNAUTHORIZED_EVENT = ::miden::protocol::auth::AUTH_UNAUTHORIZED_EVENTwithuse miden::protocol::auth::AUTH_UNAUTHORIZED_EVENTCloses #2392