Merged
Conversation
|
Cursor Agent can help with this pull request. Just |
- output_note.masm: lowercase 'check' and 'store' comments - memory.masm: lowercase 'for', 'if', and 'we' comments - bridge_in.masm: lowercase 'push' and 'check' comments Section header comments (preceding lines with # -----) are left uppercase as intended. Co-authored-by: marti <marti@hungrycats.studio>
Co-authored-by: marti <marti@hungrycats.studio>
67001ad to
e231073
Compare
PhilippGackstatter
approved these changes
Feb 4, 2026
Contributor
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Thanks!
I would actually prefer if these were uppercase, which would be more in line with english grammar and doc comments. It's pretty awkward to write comments with multiple sentences where I'm never sure whether to start the second sentence lower or uppercase, as both violate either grammar or masm conventions 😅
afa7789
pushed a commit
to afa7789/miden-base
that referenced
this pull request
Mar 9, 2026
…le-compliance-check-eefd MASM lowercase inline comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix MASM inline comment casing to adhere to convention.
This PR addresses MASM commenting conventions by converting the first letter of inline comments (prefixed with
#) to lowercase.Comments preceding section headers (lines with
# -----) were intentionally excluded from this change.