chore: Add safe constructor and validation fns to signed block#2382
Merged
chore: Add safe constructor and validation fns to signed block#2382
Conversation
bobbinth
reviewed
Feb 2, 2026
Contributor
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you. I left a few small comments inline.
c0f7210 to
aa5f97c
Compare
Contributor
Author
|
I had to force push new commits to add gpg signatures. I don't know why my commits sometimes don't have them. |
PhilippGackstatter
approved these changes
Feb 3, 2026
afa7789
pushed a commit
to afa7789/miden-base
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Signed block has a nominal implementation and we need to expand it so that the node can validate signed block contents cleanly.
Changes
SignedBlock::new()as a safe alternative tonew_unchecked()SignedBlock.