refactor: remove redundant note storage item count from advice map#2376
Merged
PhilippGackstatter merged 3 commits into0xMiden:nextfrom Feb 2, 2026
Merged
Conversation
3352621 to
aa61bc2
Compare
Since note storage items are no longer padded (after PR 0xMiden#2232), the actual length of storage_items in the advice map equals num_items. The separate advice map entry for storage item count is therefore redundant. This change removes: - The advice map entry inserting num_storage_items (tx_args.rs) - The lookup and validation of num_storage_items (kernel_process.rs) - The test assertion for the removed advice map entry (test_note.rs) Closes 0xMiden#2317
aa61bc2 to
440aaab
Compare
afa7789
pushed a commit
to afa7789/miden-base
that referenced
this pull request
Mar 9, 2026
…den#2376) Since note storage items are no longer padded (after PR 0xMiden#2232), the actual length of storage_items in the advice map equals num_items. The separate advice map entry for storage item count is therefore redundant. This change removes: - The advice map entry inserting num_storage_items (tx_args.rs) - The lookup and validation of num_storage_items (kernel_process.rs) - The test assertion for the removed advice map entry (test_note.rs) Closes 0xMiden#2317 Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since note storage items are no longer padded (after #2232), the actual length of
storage_itemsin the advice map equalsnum_items. The separate advice map entry for the storage item count is therefore redundant.Removed:
num_storage_itemsintx_args.rsnum_storage_itemsinkernel_process.rstest_note.rsCloses #2317