refactor: make tx kernel procedure offset constants public#2375
Merged
PhilippGackstatter merged 5 commits into0xMiden:nextfrom Feb 9, 2026
Merged
Conversation
454ef86 to
aa13e9c
Compare
crates/miden-protocol/asm/shared_utils/util/kernel_proc_offsets.masm
Outdated
Show resolved
Hide resolved
…he kernel This exports the kernel procedure offset constants so they can be used by code outside the kernel, such as note scripts that need to call kernel procedures dynamically. Changes: - Make offset constants public in kernel_proc_offsets.masm - Update build.rs regex to handle pub const declarations Closes 0xMiden#2342
aa13e9c to
d240e3c
Compare
Resolve merge conflicts with recent changes: - 0xMiden#2369: Updated offset numbers for new get_asset API - 0xMiden#2377: Keep pub const prefix for all offset constants
PhilippGackstatter
approved these changes
Feb 9, 2026
Contributor
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Looks good, thanks!
afa7789
pushed a commit
to afa7789/miden-base
that referenced
this pull request
Mar 9, 2026
) * feat: make kernel procedure offset constants public for use outside the kernel This exports the kernel procedure offset constants so they can be used by code outside the kernel, such as note scripts that need to call kernel procedures dynamically. Changes: - Make offset constants public in kernel_proc_offsets.masm - Update build.rs regex to handle pub const declarations Closes 0xMiden#2342 * refactor: replace accessor procedures with direct public constant usage --------- Co-authored-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kernel_proc_offsets.masmfromprotocol/toshared_utils/util/pub constdeclarationspub constsyntaxCloses #2342