Fix test failure and clippy warning in crypto_utils after adopting bytes_to_packed_u32_felts#2360
Merged
mmagician merged 4 commits intommagician-use-byte-felt-helperfrom Jan 28, 2026
Merged
Conversation
Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Chore: Use
Fix test failure and clippy warning in crypto_utils after adopting bytes_to_packed_u32_felts
Jan 28, 2026
bytes_to_packed_u32_felts instead of custom definition
Collaborator
|
@copilot make sure you address fmt and lints |
Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
Contributor
Author
fb0d179
into
mmagician-use-byte-felt-helper
14 of 15 checks passed
mmagician
added a commit
that referenced
this pull request
Jan 29, 2026
… `miden-base` (#2359) * chore: use the helper from vm * Fix test failure and clippy warning in crypto_utils after adopting bytes_to_packed_u32_felts (#2360) * Initial plan * Fix lint and test failures: pad felts and keep FieldElement import Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> * Add constant for LEAF_DATA_FELTS to improve code maintainability Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> * Apply rustfmt formatting to comment line length Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
afa7789
pushed a commit
to afa7789/miden-base
that referenced
this pull request
Mar 9, 2026
… `miden-base` (0xMiden#2359) * chore: use the helper from vm * Fix test failure and clippy warning in crypto_utils after adopting bytes_to_packed_u32_felts (0xMiden#2360) * Initial plan * Fix lint and test failures: pad felts and keep FieldElement import Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> * Add constant for LEAF_DATA_FELTS to improve code maintainability Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> * Apply rustfmt formatting to comment line length Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
miden_crypto::FieldElementfrom crypto_utils.rstest_keccak_hash_get_leaf_value- assertion expects 32 felts but gets 29make formatto ensure code formatting is correctmake fixandmake clippyto verify all linting passes💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.