Merged
Conversation
InitStorageData followups
8f2481b to
4a6e844
Compare
PhilippGackstatter
approved these changes
Feb 3, 2026
Contributor
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Looks good to me. I did not really review the code in crates/miden-protocol/src/account/component/storage/schema/* since it sounds like that was only moved and not changed.
crates/miden-protocol/src/account/component/storage/value_name.rs
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
Didn't merge this in case @bobbinth or anyone else wants to take a look, but AFAICT it should be ok to merge as of right now as it's mostly minor refactors. |
afa7789
pushed a commit
to afa7789/miden-base
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-
felt.rs-
word.rs-
slot.rs-
value_slot.rs-
map_slot.rs-
tests.rsimpl TryInto<_>for name types in parameters for building schemas. Adds conversion traits forStorageSlotNameandStorageValueName. Also updates tests to use this