Conversation
e444255 to
6165e4a
Compare
83492c1 to
227dc21
Compare
grjte
approved these changes
Dec 14, 2022
Contributor
grjte
left a comment
There was a problem hiding this comment.
Looks great! I left a few minor non-blocking comments
227dc21 to
558962c
Compare
vlopes11
reviewed
Dec 14, 2022
vlopes11
left a comment
There was a problem hiding this comment.
Looks nice! Couple of suggestions & questions
558962c to
4de6b75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
AccountIdstruct which describes the shape and properties of all account Ids in the Miden rollup.The PR also sets up the basic crate structure for the repo.