Merged
Conversation
bobbinth
approved these changes
Jan 14, 2026
Contributor
bobbinth
left a comment
There was a problem hiding this comment.
Looks great! Thank you! I left just a few small comments inline.
PhilippGackstatter
approved these changes
Jan 14, 2026
Contributor
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Looks good to me.
I think the tests can be simplified, but not critical.
531ad05 to
f621e3f
Compare
- Rename ConversionError to DecodingError for clearer semantics - Add DOUBLE_WORD_LEN constant to replace magic number 8 - Refactor to_elements() to return an iterator instead of Vec - Simplify tests using round-trip pattern per PhilippGackstatter's suggestion
f621e3f to
6c635c5
Compare
bobbinth
approved these changes
Jan 14, 2026
Contributor
bobbinth
left a comment
There was a problem hiding this comment.
All looks good! Thank you!
sergerad
added a commit
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a conversion function for a list of Felts to
SmtLeaf.Closes #772.