Conversation
|
Ah, for crying out loud, I sat on this for too long and we already have #19108 open... 😓 I guess this is still valuable for the font size part though. (Discussing at #19108 (comment) about dropping the first two commits of this PR, and only keep the font size parts) |
719afa0 to
616a07e
Compare
noahtallen
left a comment
There was a problem hiding this comment.
The code looks good to me. It also tests great locally!
One thought -- I notice the paragraph block uses a new inline mechanism for font. Should we add this too?
@noahtallen Oh, I missed that! EDIT: Ah, never mind, that comes from CoBlocks. 🙂 |
|
oh my 😁 my bad! That's some good stuff. We should have that |
|
Who should we ping on this? I think it should be ready to go. I can't think of any reason to not have it. |
|
@noahtallen I'm not sure, but the codeowners have been automagically pinged already. 🙂 |
talldan
left a comment
There was a problem hiding this comment.
This is working nicely, thanks for the addition.
It'd be great to remove that one classname before merging.
| > | ||
| <BlockNavigationList clientId={ clientId } /> | ||
| </PanelBody> | ||
| <PanelBody title={ __( 'Text Settings' ) } className="blocks-font-size"> |
There was a problem hiding this comment.
The blocks-font-size class doesn't seem to do anything, so I think it'd be good to remove it. I did a search of the codebase and it looks like it's only used in end-to-end tests in the paragraph block.
Update: I put together a PR (#19208) to remove it entirely from the codebase. It looks like there used to be styles for this class in the paragraph block, but they've been removed. The e2e tests were updated to use a different classname in that PR.
| <PanelBody title={ __( 'Text Settings' ) } className="blocks-font-size"> | |
| <PanelBody title={ __( 'Text Settings' ) }> |
There was a problem hiding this comment.
Oh good catch! Removed in 6789b26.
I'll merge as soon as tests are clear!
Description
Adds the font size style attributes (both named and custom) to the Navigation block.
How has this been tested?
Tested on macOS 10.15.2, Chrome 78, Gutenberg Docker environment, Twenty Twenty theme.
Screenshots
Testing instructions
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: