Remove unused blocks-font-size classname#19208
Merged
draganescu merged 1 commit intomasterfrom Dec 20, 2019
Merged
Conversation
6 tasks
draganescu
approved these changes
Dec 20, 2019
Contributor
draganescu
left a comment
There was a problem hiding this comment.
I have tested this. Initially I found the "default" setting to be missing but after a rebase everything was OK. All good codewise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a very tiny PR that removes a classname
blocks-font-sizesfrom the paragraph block's Text Settings panel.The css for this classname seem to have been removed a while ago from the paragraph block, so removing it has no visual effect. The only usage was in an end-to-end test where it was used as part of a selector, but this was easily replaced with the font-size-picker classname.
How has this been tested?
Types of changes
Non-breaking task
Checklist: