Skip to content

Output hash of created commit#172

Merged
stefanzweifel merged 2 commits intostefanzweifel:masterfrom
webignition:issue-171
Sep 10, 2021
Merged

Output hash of created commit#172
stefanzweifel merged 2 commits intostefanzweifel:masterfrom
webignition:issue-171

Conversation

@webignition
Copy link
Copy Markdown
Contributor

@webignition webignition commented Sep 10, 2021

Adds commit_hash output populated with the full commit hash where relevant.

Fixes #171

@webignition
Copy link
Copy Markdown
Contributor Author

webignition commented Sep 10, 2021

I now notice that checks are currently only run on push events. Running the tests and linter workflows on pull requests should make it harder for contributors to get buggy code into master. Shall I create a PR for that also?

@webignition
Copy link
Copy Markdown
Contributor Author

webignition commented Sep 10, 2021

I should probably also update the readme ...

@stefanzweifel
Copy link
Copy Markdown
Owner

stefanzweifel commented Sep 10, 2021

I now notice that checks are currently only run on push events. Running the tests and linter workflows on pull requests should make it harder for contributors to get buggy code into master. Shall I create a PR for that also?

Feel free to PR this too.

Will have a closer look at this PR in the next couple of days … or when you feel the PR is ready to review. Thanks for your contribution!

@webignition
Copy link
Copy Markdown
Contributor Author

webignition commented Sep 10, 2021

The PR for workflow updates is at /pull/173.

@webignition
Copy link
Copy Markdown
Contributor Author

webignition commented Sep 10, 2021

Now that /pull/172 is merged, I'll rebase and push to this PR again and hopefully that should get some checks to run.

@stefanzweifel
Copy link
Copy Markdown
Owner

stefanzweifel commented Sep 10, 2021

Lovely. Will take a closer look this evening and merge and tag a new version.

@webignition
Copy link
Copy Markdown
Contributor Author

webignition commented Sep 10, 2021

👍 Marvellous, cheers!

@stefanzweifel stefanzweifel merged commit 216b25a into stefanzweifel:master Sep 10, 2021
queilawithaQ
queilawithaQ reviewed Dec 10, 2021
View reviewed changes
Copy link
Copy Markdown

@queilawithaQ queilawithaQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#172 tests/git-auto-commit

@@ -150,8 +154,7 @@ git_auto_commit() {

 assert_line "INPUT_REPOSITORY value: ${INPUT_REPOSITORY}"
 assert_line "::set-output name=changes_detected::true"

 assert_line "::set-output name=changes_detected::true"
 refute_line -e "::set-output name=commit_hash::[0-9a-f]{40}$"
 assert_line "INPUT_BRANCH value: master"
 assert_line "INPUT_FILE_PATTERN: ."
 assert_line "INPUT_COMMIT_OPTIONS: "

@webignition webignition deleted the issue-171 branch December 10, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefanzweifel stefanzweifel stefanzweifel approved these changes

+1 more reviewer

@queilawithaQ queilawithaQ queilawithaQ left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Output hash of created commit

3 participants

@webignition @stefanzweifel @queilawithaQ