Run git-auto-commit, linter and tests checks on pull requests#173
Merged
stefanzweifel merged 2 commits intostefanzweifel:masterfrom Sep 10, 2021
Merged
Conversation
Owner
|
Thanks! For now, I've reverted the linter to only run on a push event. tests are imho much more important. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the on-event definitions for the
git-auto-commit,linterandtestsworkflows.The relevant workflows run only on
pushevents. Triggering these workflows onpull_requestevent ensures that checks will run when pull request are opened. This allows contributions from forks to have checks run.on-pushevents to only pushes into masterCurrently these workflows are triggered by
pushevents to any branch. Since changes should only be introduced tomastervia pull requests, triggering these workflows on allpushevents seems unnecessary.Summary: