Add include_all_metadata to conversations.replies API arguments#1270
Merged
filmaj merged 1 commit intoslackapi:mainfrom Sep 29, 2022
Merged
Add include_all_metadata to conversations.replies API arguments#1270filmaj merged 1 commit intoslackapi:mainfrom
filmaj merged 1 commit intoslackapi:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1270 +/- ##
==========================================
- Coverage 86.64% 86.14% -0.50%
==========================================
Files 111 84 -27
Lines 11027 7773 -3254
==========================================
- Hits 9554 6696 -2858
+ Misses 1473 1077 -396 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
WilliamBergamin
approved these changes
Sep 29, 2022
Contributor
WilliamBergamin
left a comment
There was a problem hiding this comment.
Simple clean fix 💯 looks good to me
filmaj
approved these changes
Sep 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
To align with slackapi/java-slack-sdk#1059, this pull request adds the missing argument to conversations_replies method.
see also: https://api.slack.com/methods/conversations.replies
Category (place an
xin each of the[ ])/docs-src(Documents, have you run./scripts/docs.sh?)/docs-src-v2(Documents, have you run./scripts/docs-v2.sh?)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements (place an
xin each[ ])python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.