Skip to content

Fix #1058 Add include_all_metadata to conversations.replies arguments#1059

Merged
seratch merged 2 commits intoslackapi:mainfrom
scarytom:include_all_metadata
Sep 27, 2022
Merged

Fix #1058 Add include_all_metadata to conversations.replies arguments#1059
seratch merged 2 commits intoslackapi:mainfrom
scarytom:include_all_metadata

Conversation

@scarytom
Copy link
Copy Markdown
Contributor

@scarytom scarytom commented Sep 27, 2022 •
edited by seratch
Loading

This pull request resolves #1058

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

@seratch seratch changed the title Support include_all_metadata argument on the conversations.replies API. Fix #1058 Support include_all_metadata argument on the conversations.replies API Sep 27, 2022
@seratch seratch self-assigned this Sep 27, 2022
@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client labels Sep 27, 2022
@seratch seratch added this to the 1.26.0 milestone Sep 27, 2022
@seratch seratch changed the title Fix #1058 Support include_all_metadata argument on the conversations.replies API Fix #1058 Add include_all_metadata conversations.replies argumentw Sep 27, 2022
@seratch seratch changed the title Fix #1058 Add include_all_metadata conversations.replies argumentw Fix #1058 Add include_all_metadata conversations.replies arguments Sep 27, 2022
@seratch seratch changed the title Fix #1058 Add include_all_metadata conversations.replies arguments Fix #1058 Add include_all_metadata to conversations.replies arguments Sep 27, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 27, 2022

Codecov Report

Merging #1059 (0f81693) into main (40b9f2b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1059      +/-   ##
============================================
+ Coverage     76.77%   76.78%   +0.01%     
- Complexity     3717     3718       +1     
============================================
  Files           407      407              
  Lines         11196    11197       +1     
  Branches       1112     1112              
============================================
+ Hits           8596     8598       +2     
  Misses         1929     1929              
+ Partials        671      670       -1
Impacted Files Coverage Δ
...java/com/slack/api/methods/RequestFormBuilder.java 88.40% <100.00%> (+<0.01%) ⬆️
...imits/metrics/impl/BaseMemoryMetricsDatastore.java 80.08% <0.00%> (+0.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch
Copy link
Copy Markdown
Contributor

seratch commented Sep 27, 2022

@scarytom Thanks for your contribution!

@seratch seratch merged commit e7dfbce into slackapi:main Sep 27, 2022
@scarytom scarytom deleted the include_all_metadata branch September 27, 2022 18:38
This was referenced Sep 29, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@seratch seratch seratch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@seratch seratch

Labels

enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

Support "include_all_metadata" argument on conversations.replies

2 participants

@scarytom @seratch