[Php56] Skip after infinite loop on AddDefaultValueForUndefinedVariableRector#3390
Merged
samsonasik merged 13 commits intomainfrom Feb 19, 2023
Merged
[Php56] Skip after infinite loop on AddDefaultValueForUndefinedVariableRector#3390samsonasik merged 13 commits intomainfrom
samsonasik merged 13 commits intomainfrom
Conversation
…r with infinite loop # Failing Test for AddDefaultValueForUndefinedVariableRector Based on https://getrector.com/demo/e1b4cf4e-c34f-466d-ac1a-4ecdbffca61c
Member
Author
|
Oh, it seems can't be resolved by check first stmt as first stmt can be multiple condition, for example: echo 'test';
while (true !== false) {
}that still added. I added more failing fixture for it e78c0ee |
Member
Author
|
I am not sure about this, the question is why create abvious infinite loop on early code in the first place :) while (true !== false) {
}
$a = [];
if ($b = $yes) {
$a[] = 'test';
}
return $a;I am closing this for now. |
Member
Author
|
Re-open, @jackbentley it seems it can be resolved by check parent Node of Stmt is an Unreachable stmt on |
Member
Author
|
Finally, All checks have passed 🎉 @TomasVotruba it is ready for review. |
Member
Author
|
@TomasVotruba I am merging it ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3388
Fixes rectorphp/rector#7777