Install pak into the site library#640
Merged
gaborcsardi merged 21 commits intov2-branchfrom Oct 20, 2022
Merged
Conversation
This probably fails on Unix, I don't think that we can write to the site library, or even create it, without `sudo`.
On Windows at least.
Codecov Report
@@ Coverage Diff @@
## v2-branch #640 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 2 2
Lines 10 10
===========================================
Hits 10 10 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Something is messed up with GITHUB_ENV in composite actions.
As we always use pak from the site lib now.
To avoid mark pak as disk-mismatch, if it is also in the user library.
This reverts commit 40c7ba5. Better to still exclude pak, because pak might try to load its dependencies from the wrong library, because of a bug.
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This probably fails on Unix, I don't think that we can write to the site library, or even create it, without
sudo.Closes #522.