[WorkflowRun] - Add missing attributes (run_started_at & run_attempt), remove deprecated unicode type#2273
Merged
sfdye merged 3 commits intoPyGithub:masterfrom Oct 29, 2022
Conversation
1f2afe6 to
9e6c39e
Compare
run_started_at and run_attempt attributesrun_started_at & run_attempt), remove deprecated unicode type
Codecov ReportBase: 98.80% // Head: 98.77% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2273 +/- ##
==========================================
- Coverage 98.80% 98.77% -0.04%
==========================================
Files 110 110
Lines 11305 11320 +15
==========================================
+ Hits 11170 11181 +11
- Misses 135 139 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
Author
|
@sfdye @s-t-e-v-e-n-k @marcorosa I can't assign anyone to this PR, but it's ready :) Thanks a lot for reviewing! |
d8ff866 to
5bfc9c5
Compare
sfdye
approved these changes
Oct 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the title, this PR adds the
run_started_atandrun_attemptattributes to the WorkflowRun class, following the Github API reference page: https://docs.github.com/en/rest/actions/workflow-runs#get-a-workflow-run .In addition, I removed the
unicodetype since it is no longer supported by Python3, and has been absorbed into thestrtype. Using theunicodetype in Python3 will cause errors, so I removed all references to this type.This PR is consolidating the changes from PR #2274 , as recommended by @marcorosa .