[Bug fix] - Remove references to unicode type, no longer supported in Python3#2274
Closed
goliaro wants to merge 3 commits intoPyGithub:masterfrom
Closed
[Bug fix] - Remove references to unicode type, no longer supported in Python3#2274goliaro wants to merge 3 commits intoPyGithub:masterfrom
unicode type, no longer supported in Python3#2274goliaro wants to merge 3 commits intoPyGithub:masterfrom
Conversation
|
You don't just fix a unicode type reference here, but also introduce 2 (missing) workflow attributes, so you'd better specify this in the description. |
|
Just noticed there is #2273 open that is same as this PR, I think you can leave open just one of them not to have the same review twice |
Contributor
Author
|
Consolidating the two PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
unicodetype is no longer supported by Python3, and has been absorbed into thestrtype. Using theunicodetype in Python3 will cause errors, so I removed all references to this type