TypeScript: avoid trailing commas on index signatures with only one parameter#7836
Merged
thorn0 merged 3 commits intoprettier:masterfrom Mar 23, 2020
Merged
TypeScript: avoid trailing commas on index signatures with only one parameter#7836thorn0 merged 3 commits intoprettier:masterfrom
thorn0 merged 3 commits intoprettier:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7834. Specifically, it now outputs the trailing comma only when there's multiple parameters. In the usual (non-error) case, it treats it like a computed property name and therefore omits the trailing comma.
See #7224 and #7228 for some context.
changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨