Fix printing both index signatures without type annotations and multi-parameter index signatures#7228
Merged
lipis merged 9 commits intoprettier:masterfrom Jan 8, 2020
Merged
Conversation
Contributor
Author
|
I guess I can fix #7224 quickly, but should I commit and push to this branch to avoid conflicts? Or is it better to create a new PR for that? |
thorn0
requested changes
Jan 6, 2020
thorn0
requested changes
Jan 6, 2020
| [key: string]: any; | ||
| } | ||
|
|
||
| type A = { [key: string] }; |
Member
There was a problem hiding this comment.
As an index signature without a type annotation is not valid TS, please move the test for this case to a separate file in tests/typescript_error_recovery.
Member
Contributor
Author
sosukesuzuki
reviewed
Jan 6, 2020
Contributor
sosukesuzuki
left a comment
There was a problem hiding this comment.
What about the case it is long?
// Input
type T = {
[loooooooooooooooooooooooooong: string, looooooooooooooooooooooooooooooooooooooong: string]: string;
}
// Output
type T = {
[loooooooooooooooooooooooooong: string, looooooooooooooooooooooooooooooooooooooong: string]: string;
};
// Expected
type T = {
[
loooooooooooooooooooooooooong: string,
looooooooooooooooooooooooooooooooooooooong: string
]: string;
};Also, we should support trailing commas.
Contributor
Author
|
@sosukesuzuki san, |
thorn0
approved these changes
Jan 7, 2020
Co-Authored-By: Georgii Dolzhykov <thorn.mailbox@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7225
docs/directory)changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨