Support non-empty-array in InArrayFunctionTypeSpecifyingExtension by staabm · Pull Request #1108 · phpstan/phpstan-src

staabm · 2022-03-23T16:27:43Z

as requested in phpstan/phpstan#6863 (comment)

staabm · 2022-03-23T17:26:45Z

src/Type/Php/InArrayFunctionTypeSpecifyingExtension.php

it seems this intersection alters some array-types, so they no longer get reported as TRUE by the ImpossibleTypeChecker.. still investigating..

had to add a lot of checks, to make the test-suite - especially the ImpossibleTypeChecker - happy, see e.g. for errors which happen, without these checks

... 1) PHPStan\Rules\Comparison\ImpossibleCheckTypeFunctionCallRuleTest::testImpossibleCheckTypeFunctionCall Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ 194: Call to function method_exists() with $this(CheckTypeFunctionCall\FinalClassWithMethodExists) and 'doBar' will always evaluate to false. 209: Call to function property_exists() with $this(CheckTypeFunctionCall\FinalClassWithPropertyExists) and 'fooProperty' will always evaluate to true. 212: Call to function property_exists() with $this(CheckTypeFunctionCall\FinalClassWithPropertyExists) and 'barProperty' will always evaluate to false. -235: Call to function in_array() with arguments int, array{'foo', 'bar'} and true will always evaluate to false. -244: Call to function in_array() with arguments 'bar'|'foo', array{'baz', 'lorem'} and true will always evaluate to false. -248: Call to function in_array() with arguments 'bar'|'foo', array{'foo', 'bar'} and true will always evaluate to true. -252: Call to function in_array() with arguments 'foo', array{'foo'} and true will always evaluate to true. -256: Call to function in_array() with arguments 'foo', array{'foo', 'bar'} and true will always evaluate to true. 320: Call to function in_array() with arguments 'bar', array{}|array{'foo'} and true will always evaluate to false. -336: Call to function in_array() with arguments 'baz', array{0: 'bar', 1?: 'foo'} and true will always evaluate to false. -343: Call to function in_array() with arguments 'foo', array{} and true will always evaluate to false. 360: Call to function array_key_exists() with 'a' and array{a: 1, b?: 2} will always evaluate to true. 366: Call to function array_key_exists() with 'c' and array{a: 1, b?: 2} will always evaluate to false. 560: Call to function is_string() with mixed will always evaluate to false. C:\dvl\Workspace\phpstan-src-staabm\src\Testing\RuleTestCase.php:131 C:\dvl\Workspace\phpstan-src-staabm\tests\PHPStan\Rules\Comparison\ImpossibleCheckTypeFunctionCallRuleTest.php:47 2) PHPStan\Rules\Comparison\ImpossibleCheckTypeFunctionCallRuleTest::testImpossibleCheckTypeFunctionCallWithoutAlwaysTrue Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ 105: Call to function is_numeric() with 'blabla' will always evaluate to false. 194: Call to function method_exists() with $this(CheckTypeFunctionCall\FinalClassWithMethodExists) and 'doBar' will always evaluate to false. 212: Call to function property_exists() with $this(CheckTypeFunctionCall\FinalClassWithPropertyExists) and 'barProperty' will always evaluate to false. -235: Call to function in_array() with arguments int, array{'foo', 'bar'} and true will always evaluate to false. -244: Call to function in_array() with arguments 'bar'|'foo', array{'baz', 'lorem'} and true will always evaluate to false. 320: Call to function in_array() with arguments 'bar', array{}|array{'foo'} and true will always evaluate to false. -336: Call to function in_array() with arguments 'baz', array{0: 'bar', 1?: 'foo'} and true will always evaluate to false. -343: Call to function in_array() with arguments 'foo', array{} and true will always evaluate to false. 366: Call to function array_key_exists() with 'c' and array{a: 1, b?: 2} will always evaluate to false. 560: Call to function is_string() with mixed will always evaluate to false. 571: Call to function is_callable() with mixed will always evaluate to false. C:\dvl\Workspace\phpstan-src-staabm\src\Testing\RuleTestCase.php:131 C:\dvl\Workspace\phpstan-src-staabm\tests\PHPStan\Rules\Comparison\ImpossibleCheckTypeFunctionCallRuleTest.php:256 3) PHPStan\Rules\Comparison\ImpossibleCheckTypeFunctionCallRuleTest::testBugInArrayDateFormat Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ '39: Call to function in_array() with arguments 'a', non-empty-array<int, 'a'> and true will always evaluate to true. 43: Call to function in_array() with arguments 'b', non-empty-array<int, 'a'> and true will always evaluate to false. -47: Call to function in_array() with arguments int, array{} and true will always evaluate to false. ' ...

I am pretty sure, there is some kind of check which should be done instead, but I did not find it yet

hmm maybe there is some kind of cache invalidated, because the type is altered within the type-specifying-extension?

e.g. intersecting array{'foo', 'bar'} with NonEmptyArrayType does not change the type itself, but it feels like since we get a new object this has some kind of side-effect on the ImpossibleTypeChecker..

investigation still goes on...

before this PR, phpstan took this path to return false

phpstan-src/src/Rules/Comparison/ImpossibleCheckTypeHelper.php

Lines 201 to 220 in a355aaa

if (count($sureTypes) === 1 && count($sureNotTypes) === 0) {

$sureType = reset($sureTypes);

if ($isSpecified($sureType[0])) {

return null;

}

if ($this->treatPhpDocTypesAsCertain) {

$argumentType = $scope->getType($sureType[0]);

} else {

$argumentType = $scope->getNativeType($sureType[0]);

}

/** @var Type $resultType */

$resultType = $sureType[1];

$isSuperType = $resultType->isSuperTypeOf($argumentType);

if ($isSuperType->yes()) {

return true;

} elseif ($isSuperType->no()) {

return false;

which produced the errors, now missing with this PR applied. after this change we have more then 1 sureType, and therefore the code takes a different path.

I am getting the feeling, that a TypeSpecifyingExtension cannot specify types for different expressions in one run.

I cannot find any other TypeSpecifyingExtension wich uses unionWith. also every other TypeSpecifyingExtension which I checked in the codebase always specifies its type for a single arg.

starting wit 1cb657f I changed the TypeSpecifyingExtension to drop these hopefully unneeded checks for a change in the ImpossibleTypeChecker

staabm · 2022-03-25T16:22:48Z

src/Rules/Comparison/ImpossibleCheckTypeHelper.php

instead of union togehter all types within $sureNotTypes, we now take the $expr into account, and union only these refering to the same expr.

adding this here to support the change in InArrayFunctionTypeSpecifyingExtension regresses some other parts.
I am not sure how this should progress further and therefore wait for a first round of review from ondrey.

rvanvelzen · 2022-06-17T08:08:49Z

The changes in #1430 should make it possible to finish this as well :)

ondrejmirtes · 2022-06-17T08:17:34Z

I've rebased it to see how the code works :)

ondrejmirtes · 2022-06-17T08:18:54Z

Wow, looks like it works in the first try :)

ondrejmirtes · 2022-06-17T08:22:30Z

Thank you!

staabm · 2022-06-17T08:40:17Z

Thank you guys!

clxmstaab force-pushed the in-array branch from f26a1f9 to 0f6720e Compare March 23, 2022 16:32

staabm marked this pull request as ready for review March 23, 2022 16:32

staabm marked this pull request as draft March 23, 2022 16:33

clxmstaab force-pushed the in-array branch from 109da9c to 651efa1 Compare March 23, 2022 16:42

staabm commented Mar 23, 2022

View reviewed changes

clxmstaab force-pushed the in-array branch from da019ca to 8e42b32 Compare March 23, 2022 17:59

staabm marked this pull request as ready for review March 23, 2022 18:54

staabm force-pushed the in-array branch from 8e42b32 to 9d6a3cc Compare March 24, 2022 13:38

clxmstaab force-pushed the in-array branch 2 times, most recently from f881f1e to 1cb657f Compare March 25, 2022 16:20

staabm commented Mar 25, 2022

View reviewed changes

staabm force-pushed the in-array branch from d06ca39 to 0be6370 Compare March 28, 2022 07:58

staabm marked this pull request as draft March 30, 2022 13:01

clxmstaab force-pushed the in-array branch 2 times, most recently from 927a1d8 to b627cdc Compare April 4, 2022 09:56

ondrejmirtes force-pushed the 1.5.x branch from 20539b3 to 9bb13b0 Compare April 19, 2022 11:20

ondrejmirtes force-pushed the in-array branch from b627cdc to 337c987 Compare April 27, 2022 20:49

ondrejmirtes changed the base branch from 1.5.x to 1.6.x April 27, 2022 20:49

staabm force-pushed the in-array branch from 337c987 to 2c47503 Compare April 28, 2022 05:33

clxmstaab force-pushed the in-array branch from 2c47503 to f2b37e6 Compare April 28, 2022 08:59

Support non-empty-array in InArrayFunctionTypeSpecifyingExtension

a702e2e

ondrejmirtes force-pushed the in-array branch from f2b37e6 to a702e2e Compare June 17, 2022 08:17

ondrejmirtes changed the base branch from 1.6.x to 1.7.x June 17, 2022 08:17

ondrejmirtes marked this pull request as ready for review June 17, 2022 08:17

ondrejmirtes merged commit 5b2d7b6 into phpstan:1.7.x Jun 17, 2022

staabm deleted the in-array branch June 17, 2022 08:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support non-empty-array in InArrayFunctionTypeSpecifyingExtension#1108

Support non-empty-array in InArrayFunctionTypeSpecifyingExtension#1108
ondrejmirtes merged 1 commit intophpstan:1.7.xfrom
staabm:in-array

staabm commented Mar 23, 2022 •

edited

Loading

Uh oh!

staabm Mar 23, 2022 •

edited

Loading

Uh oh!

staabm Mar 23, 2022 •

edited

Loading

Uh oh!

staabm Mar 24, 2022

Uh oh!

staabm Mar 25, 2022

Uh oh!

staabm Mar 25, 2022 •

edited

Loading

Uh oh!

staabm Mar 25, 2022 •

edited

Loading

Uh oh!

rvanvelzen commented Jun 17, 2022

Uh oh!

ondrejmirtes commented Jun 17, 2022

Uh oh!

ondrejmirtes commented Jun 17, 2022

Uh oh!

ondrejmirtes commented Jun 17, 2022

Uh oh!

staabm commented Jun 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	if (count($sureTypes) === 1 && count($sureNotTypes) === 0) {
	$sureType = reset($sureTypes);
	if ($isSpecified($sureType[0])) {
	return null;
	}

	if ($this->treatPhpDocTypesAsCertain) {
	$argumentType = $scope->getType($sureType[0]);
	} else {
	$argumentType = $scope->getNativeType($sureType[0]);
	}

	/** @var Type $resultType */
	$resultType = $sureType[1];

	$isSuperType = $resultType->isSuperTypeOf($argumentType);
	if ($isSuperType->yes()) {
	return true;
	} elseif ($isSuperType->no()) {
	return false;

Conversation

staabm commented Mar 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

staabm Mar 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

staabm Mar 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

staabm Mar 24, 2022

Choose a reason for hiding this comment

Uh oh!

staabm Mar 25, 2022

Choose a reason for hiding this comment

Uh oh!

staabm Mar 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

staabm Mar 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rvanvelzen commented Jun 17, 2022

Uh oh!

ondrejmirtes commented Jun 17, 2022

Uh oh!

ondrejmirtes commented Jun 17, 2022

Uh oh!

ondrejmirtes commented Jun 17, 2022

Uh oh!

staabm commented Jun 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

staabm commented Mar 23, 2022 •

edited

Loading

staabm Mar 23, 2022 •

edited

Loading

staabm Mar 23, 2022 •

edited

Loading

staabm Mar 25, 2022 •

edited

Loading

staabm Mar 25, 2022 •

edited

Loading